Skip to content

Check if targets of links "out of root" exists#59

Closed
kolibri91 wants to merge 9 commits intomanuzhang:mainfrom
kolibri91:feature/out-of-root
Closed

Check if targets of links "out of root" exists#59
kolibri91 wants to merge 9 commits intomanuzhang:mainfrom
kolibri91:feature/out-of-root

Conversation

@kolibri91
Copy link
Copy Markdown
Contributor

TBD

Closes #58

@@ -1,4 +1,4 @@
strict: True
strict: False
Copy link
Copy Markdown
Contributor

@johnthagen johnthagen Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will want to revert this before final merge.

Copy link
Copy Markdown
Contributor Author

@kolibri91 kolibri91 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, but I'm wondering you how got it work within your example.
I normally get this warning:

WARNING  -  Documentation file 'index.md' contains a link to '..\..\..\README.md' which is not found in the documentation files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, but I'm wondering you how got it work within your example. I normally get this warning:

WARNING  -  Documentation file 'index.md' contains a link to '..\..\..\README.md' which is not found in the documentation files.

@johnthagen Ok, got it. mkdocs complains about missing files but not folders. So, your particular example from #58 works in strict mode.

@johnthagen
Copy link
Copy Markdown
Contributor

Handle python 3.6 with mkdocs < 1.4

In my opinion Python 3.6 is end of life and we should simply drop it from the test suite. Even Python 3.7 is almost end of life (2 months).

@kolibri91
Copy link
Copy Markdown
Contributor Author

Handle python 3.6 with mkdocs < 1.4

In my opinion Python 3.6 is end of life and we should simply drop it from the test suite. Even Python 3.7 is almost end of life (2 months).

* https://endoflife.date/python

It's not up to me to decide...

@kolibri91 kolibri91 requested a review from johnthagen April 12, 2023 17:29
@johnthagen
Copy link
Copy Markdown
Contributor

@manuzhang Would you have any issues with dropping Python 3.6 support since that is end of life?

@manuzhang
Copy link
Copy Markdown
Owner

@manuzhang Would you have any issues with dropping Python 3.6 support since that is end of life?

No, but let's do it in a separate PR and update test workflows, README, etc.

@kolibri91
Copy link
Copy Markdown
Contributor Author

Considering the results and the loss of strict mode, I would say this is not an improvement.

The only useful commit is 32f9c3e and this has to be contributed in a separate PR including tests.

@kolibri91 kolibri91 closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relative paths to application from user guide marked invalid

3 participants