Support Local Links without anchor#49
Merged
manuzhang merged 16 commits intomanuzhang:mainfrom Mar 6, 2023
kolibri91:feature/local-links
Merged
Support Local Links without anchor#49manuzhang merged 16 commits intomanuzhang:mainfrom kolibri91:feature/local-links
manuzhang merged 16 commits intomanuzhang:mainfrom
kolibri91:feature/local-links
Conversation
Owner
|
@kolibri91 thanks for contribution. Could you add an integration test as well? |
Contributor
Author
Sure, thanks for you feedback. I will check and contribute to the tests soon. |
Owner
|
Is the image file hand-drawn or from the web? Shall we add an attribution? |
Contributor
Author
Handdrawn by me in 2mins. Not worth to have an attribution. |
Owner
|
@kolibri91 Thanks! LGTM, merging... |
manuzhang
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally started with the problem of a link without an anchor.
Those links are currently just ignored. I changed this by another regex.
But then I ran into trouble with other files (e.g. graphics in combination with
glightbox-plugin) which have may a link as well.Solution
Optimization