Repository navigation
Phase 21 — official company logo from the owner-provided artwork - #50
Merged
Merged
Conversation
- public/brand/logo-official.jpg: the gold-framed lockup (peacock saree emblem + Sri Vartali Sarees wordmark + Telugu tagline), margin-trimmed from the provided image; app/icon.png square favicon from the same art - Single-source BrandMark component + brand constants (aspect-correct everywhere); wired into header, footer, splash, sign-in, register - Old SV medallion (logo.svg + icon.svg) removed — superseded - 5 new unit tests: constants, asset existence, real JPEG/PNG header dimension checks (297 → 302); no migration
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ManoharPaturi
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 21: the owner-provided image becomes the official company logo everywhere appropriate. The artwork (WhatsApp image, 1600×912) is the gold-framed brand lockup — peacock-with-saree emblem above the "Sri Vartali Sarees" wordmark and Telugu tagline on deep plum. Branch cut from
main@5f78270(post-Phase 20 #49). App/assets only — no migration, no new dependencies.What changed
public/brand/logo-official.jpg— the provided image, margin-trimmed to the gold frame (1590×898, 134 KB, progressive JPEG; verified intact by visual inspection: frame, emblem, wordmark, tagline all uncropped).app/icon.png— 512×512 square favicon generated from the same lockup (contained on the plum ground so no glyph is sliced).lib/storefront/brand.ts+components/storefront/brand-mark.tsx— single source of truth: constants (src, alt, pixel dimensions) + one aspect-correctBrandMarkcomponent. Swapping the official artwork in future = replace one file + the dimension constants (CI checks flag it — see tests).public/brand/logo.svg,app/icon.svg) — superseded, nothing references it (the saree motif SVGs stay; unused but harmless).Verification
npm run typecheck— cleaneslinton all changed files — cleannpm test— 302/302 (297 on main + 5 new: constant sanity/aspect, asset-existence guards, and real binary-header checks — the JPEG's SOF dimensions must match the render constants and the favicon must be a square PNG, so a deleted or mismatched logo fails CI instead of shipping)npm run build— clean/serves the official lockup in header + footer + splash (7 references incl. RSC payload, zero references to the old medallion);/account/loginand/account/registerrender it; favicon link servesicon.pngNotes for review
w-auto, footer 48–56 px, splash 160–192 px — aspect-correct at every size.@ManoharPaturi — Phase 21 is ready for your review: the logo you provided is now the site's official mark in the header, footer, splash, auth pages, and browser tab. Once the required Typecheck · Lint · Build check is green, please review, approve, and merge it yourself (per the standing rule, I never merge). Want the logo larger/smaller anywhere, or a different crop? Comment here and I'll push to this branch.