Skip to content

Phase 21 — official company logo from the owner-provided artwork - #50

Merged
ManoharPaturi merged 1 commit into
mainfrom
feat/phase21-official-logo
Oct 20, 2026
Merged

ManoharPaturi merged 1 commit into
mainfrom
feat/phase21-official-logo

Conversation

@Pushpak731

Copy link
Copy Markdown
Contributor

Summary

Phase 21: the owner-provided image becomes the official company logo everywhere appropriate. The artwork (WhatsApp image, 1600×912) is the gold-framed brand lockup — peacock-with-saree emblem above the "Sri Vartali Sarees" wordmark and Telugu tagline on deep plum. Branch cut from main @ 5f78270 (post-Phase 20 #49). App/assets only — no migration, no new dependencies.

What changed

  • public/brand/logo-official.jpg — the provided image, margin-trimmed to the gold frame (1590×898, 134 KB, progressive JPEG; verified intact by visual inspection: frame, emblem, wordmark, tagline all uncropped).
  • app/icon.png — 512×512 square favicon generated from the same lockup (contained on the plum ground so no glyph is sliced).
  • lib/storefront/brand.ts + components/storefront/brand-mark.tsx — single source of truth: constants (src, alt, pixel dimensions) + one aspect-correct BrandMark component. Swapping the official artwork in future = replace one file + the dimension constants (CI checks flag it — see tests).
  • Wired into every logo surface: storefront header (replaces the medallion; the lockup carries the wordmark itself, so the duplicate site-name span is gone), footer, splash screen (large; the duplicated name line under it removed), sign-in and register pages. Favicon switched to the PNG.
  • Removed: the interim Phase 17 SV medallion (public/brand/logo.svg, app/icon.svg) — superseded, nothing references it (the saree motif SVGs stay; unused but harmless).

Verification

  • npm run typecheck — clean
  • eslint on all changed files — clean
  • npm test — 302/302 (297 on main + 5 new: constant sanity/aspect, asset-existence guards, and real binary-header checks — the JPEG's SOF dimensions must match the render constants and the favicon must be a square PNG, so a deleted or mismatched logo fails CI instead of shipping)
  • npm run build — clean
  • Runtime on the dev server: / serves the official lockup in header + footer + splash (7 references incl. RSC payload, zero references to the old medallion); /account/login and /account/register render it; favicon link serves icon.png
  • Processed artwork visually inspected — full frame and wordmark intact, no crop artifacts

Notes for review

  • The lockup is landscape (≈1.77:1) by design; header height is 40–44 px with w-auto, footer 48–56 px, splash 160–192 px — aspect-correct at every size.
  • Rollback: revert the squash — pure app/assets.

@ManoharPaturi — Phase 21 is ready for your review: the logo you provided is now the site's official mark in the header, footer, splash, auth pages, and browser tab. Once the required Typecheck · Lint · Build check is green, please review, approve, and merge it yourself (per the standing rule, I never merge). Want the logo larger/smaller anywhere, or a different crop? Comment here and I'll push to this branch.

- public/brand/logo-official.jpg: the gold-framed lockup (peacock saree
  emblem + Sri Vartali Sarees wordmark + Telugu tagline), margin-trimmed
  from the provided image; app/icon.png square favicon from the same art
- Single-source BrandMark component + brand constants (aspect-correct
  everywhere); wired into header, footer, splash, sign-in, register
- Old SV medallion (logo.svg + icon.svg) removed — superseded
- 5 new unit tests: constants, asset existence, real JPEG/PNG header
  dimension checks (297 → 302); no migration
Copilot AI balanced review requested due to automatic review settings October 20, 2026 04:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sri-vartali-commerce Ready Ready Preview Oct 20, 2026 4:41am UTC

@ManoharPaturi
ManoharPaturi merged commit 23f2e88 into main Oct 20, 2026
4 checks passed
@ManoharPaturi
ManoharPaturi deleted the feat/phase21-official-logo branch October 20, 2026 04:48

This branch was successfully deployed

1 active deployment
Preview — 1e875292 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants