Repository navigation
Phase 18 – Center Navigation Section - #47
Conversation
justify-center + flex-wrap on the category list: centered under the wordmark at every width, wrapping to centered rows on narrow screens (with 8+ categories a single row cannot fit a phone — nowrap risked pushing the page wide). Active-route highlighting unchanged. One-file change, no new dependencies.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
@ManoharPaturi — requesting your review, approval and merge for Phase 18 – Center Navigation Section. One-file change (+4/−2): the category rail is now centered at every width and wraps to centered rows on narrow screens (also removing the latent mobile overflow from the old nowrap list). Active-link highlighting unchanged. Gates green: Per your workflow this is left unmerged — it's yours to accept and merge 🙏 |
|
@Pushpak731 something is wrong with deployment |
|
i think something is wrong with your supa-base integration |
Preview deployments on the Vercel project carry no Supabase env vars
(Production-only scoping), and createServerClient's assert threw — every
storefront page 500'd ('This page couldn't load'), which the reviewer hit
on this PR's preview. Reproduced locally by running with an empty env:
/ and /shop 500.
The README's setup invariant says pages degrade to notices, never crash:
- lib/storefront/queries.ts: the four public reads return empty/null
when !isSupabaseConfigured()
- (storefront)/layout.tsx: explicit gold banner on every page when the
deployment is unconfigured
Verified with no env: all storefront routes 200 (slug routes 404, banner
explains why); with real env: unchanged — products render, no banner.
tsc clean, 278/278 tests, lint unchanged.
Note: fully-working previews additionally need the env vars enabled for
Preview on the Vercel project (owner dashboard action) — the code side
no longer crashes without them.
|
@Pushpak731 |
…st sign-in (#48) ## Summary Three owner-requested refinements. App code only — **no migration, no new dependencies**. Branch cut from `main` @ `d40ebb9` (after #47). 5 files, +106/−54. ### 1. Professional bag cart icon The header cart marker was the 🛍 emoji. It's now a stroked boutique-bag glyph (`BagIcon` in `site-header.tsx`) — rounded 1.6px stroke to match the contact dock's WhatsApp/phone icon weight, inherits the link's hover colour, 22px optical size beside the label and count badge. ### 2. Sarees-focused navbar `Dresses · Kurtis · Lehengas · Dupattas · Accessories` leave the storefront navigation (header rail **and** footer shop column — same rule, one helper: `navVisibleCategories()` in `lib/storefront/queries.ts`). Scope is navigation only: the categories remain fully intact in the catalog — data, schema-driven facets, `/category/[slug]` pages and the spec's future fashion expansion (§4/§61) are untouched. When those lines launch, removing the slugs from one `Set` returns them to the nav. ### 3. Standard email-based sign-in `/account/login` led with the magic-link flow and hid the password form behind a toggle. Now it's the established-sites pattern: **email + password on one screen → Sign in → inline error**, with the one-time email link demoted to a clearly-labelled secondary option ("No password yet? Email me a one-time link") for accounts without a password. Page copy updated to match. Server actions, the verify route, §46 rate limits and `next` redirects are all unchanged. ## Verification - Served HTML: rail renders `Shop all · Sarees · Silk Sarees · Blouses · New arrivals · Account` (removed categories absent everywhere, incl. footer); zero emoji cart markers; login renders the password form first with `autoComplete="current-password"`. - Password auth proven end-to-end against live Supabase: HTTP 200 + session token for `[email protected]`. - `tsc` clean · eslint (1 pre-existing `main` warning only) · **278/278 unit tests** · production build green. ## Notes for reviewers - @ManoharPaturi — please review, approve and merge when satisfied; intentionally left unmerged. - Preview note: until the Preview env vars from the #47 thread are toggled, previews show the storefront with the gold setup banner (expected); the centered nav, bag icon and filtered rail are visible either way.

Summary
Owner request: center the header navigation rail (the category list under the wordmark) with proper alignment and responsiveness. One-file change (
components/storefront/header-nav.tsx, +4/−2); branch cut frommain@45ea8e7; no migration, no new dependencies.Change
justify-centercenters the list under the wordmark on desktop, tablet and mobile alike.flex-wraplets the rail wrap to centered rows on narrow screens. With 8+ categories plus Shop all / New arrivals / Account, a single row cannot fit a phone; the previousnowraplist risked pushing the page wide. Wrapping makes horizontal overflow structurally impossible (the list can never exceed its container).gap-y-1.5between wrapped rows keeps multi-row rails compact;gap-x-5horizontal rhythm unchanged.aria-current, bold + underline) is untouched.Verification
/and/shop; centering and wrap follow from flexbox semantics (justify-centercenters every wrapped row).tscclean; eslint — only the 1 pre-existingparamswarningmainalready has; 278/278 unit tests pass; production build compiles.Notes for reviewers