Skip to content

Phase 18 – Center Navigation Section - #47

Merged
ManoharPaturi merged 2 commits into
mainfrom
feat/phase18-center-navigation
Oct 18, 2026
Merged

ManoharPaturi merged 2 commits into
mainfrom
feat/phase18-center-navigation

Conversation

@Pushpak731

Copy link
Copy Markdown
Contributor

Summary

Owner request: center the header navigation rail (the category list under the wordmark) with proper alignment and responsiveness. One-file change (components/storefront/header-nav.tsx, +4/−2); branch cut from main @ 45ea8e7; no migration, no new dependencies.

Change

- <ul className="flex items-center gap-5 pb-2.5 text-[13px]">
+ <ul className="flex flex-wrap items-center justify-center gap-x-5 gap-y-1.5 pb-2.5 text-[13px]">
  • Centered at every width — justify-center centers the list under the wordmark on desktop, tablet and mobile alike.
  • Responsive without overflow — flex-wrap lets the rail wrap to centered rows on narrow screens. With 8+ categories plus Shop all / New arrivals / Account, a single row cannot fit a phone; the previous nowrap list risked pushing the page wide. Wrapping makes horizontal overflow structurally impossible (the list can never exceed its container).
  • Tighter gap-y-1.5 between wrapped rows keeps multi-row rails compact; gap-x-5 horizontal rhythm unchanged.
  • Active-route highlighting (aria-current, bold + underline) is untouched.

Verification

  • Served HTML carries the new class string on / and /shop; centering and wrap follow from flexbox semantics (justify-center centers every wrapped row).
  • tsc clean; eslint — only the 1 pre-existing params warning main already has; 278/278 unit tests pass; production build compiles.
  • No other file touched; no behavioural change to links, search, cart or wishlist icons.

Notes for reviewers

  • @ManoharPaturi — please review, approve and merge when satisfied (left unmerged intentionally).

justify-center + flex-wrap on the category list: centered under the
wordmark at every width, wrapping to centered rows on narrow screens
(with 8+ categories a single row cannot fit a phone — nowrap risked
pushing the page wide). Active-route highlighting unchanged. One-file
change, no new dependencies.
Copilot AI balanced review requested due to automatic review settings October 18, 2026 16:30
@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sri-vartali-commerce Ready Ready Preview Oct 18, 2026 5:13pm UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Pushpak731

Copy link
Copy Markdown
Contributor Author

@ManoharPaturi — requesting your review, approval and merge for Phase 18 – Center Navigation Section.

One-file change (+4/−2): the category rail is now centered at every width and wraps to centered rows on narrow screens (also removing the latent mobile overflow from the old nowrap list). Active-link highlighting unchanged.

Gates green: tsc clean · 278/278 unit tests · production build ✅ (CI running on the PR now).

Per your workflow this is left unmerged — it's yours to accept and merge 🙏

@ManoharPaturi

Copy link
Copy Markdown
Contributor

@Pushpak731 something is wrong with deployment
image
Try correcting that for a merge

@ManoharPaturi

Copy link
Copy Markdown
Contributor

i think something is wrong with your supa-base integration

Preview deployments on the Vercel project carry no Supabase env vars
(Production-only scoping), and createServerClient's assert threw — every
storefront page 500'd ('This page couldn't load'), which the reviewer hit
on this PR's preview. Reproduced locally by running with an empty env:
/ and /shop 500.

The README's setup invariant says pages degrade to notices, never crash:
- lib/storefront/queries.ts: the four public reads return empty/null
  when !isSupabaseConfigured()
- (storefront)/layout.tsx: explicit gold banner on every page when the
  deployment is unconfigured

Verified with no env: all storefront routes 200 (slug routes 404, banner
explains why); with real env: unchanged — products render, no banner.
tsc clean, 278/278 tests, lint unchanged.

Note: fully-working previews additionally need the env vars enabled for
Preview on the Vercel project (owner dashboard action) — the code side
no longer crashes without them.
@ManoharPaturi

Copy link
Copy Markdown
Contributor

@Pushpak731
still database integration is not solved
getting this msg on the page
"Store data is unavailable — this deployment is missing its Supabase environment variables. The shop appears automatically once they are configured."
for the sake of other developments i am merging this pr but configure the supabase key as soon as possible

@ManoharPaturi
ManoharPaturi merged commit d40ebb9 into main Oct 18, 2026
4 checks passed
@ManoharPaturi
ManoharPaturi deleted the feat/phase18-center-navigation branch October 18, 2026 17:17
@manohar-test123 manohar-test123 deleted a comment from Pushpak731 Oct 18, 2026
ManoharPaturi pushed a commit that referenced this pull request Oct 18, 2026
…st sign-in (#48)

## Summary

Three owner-requested refinements. App code only — **no migration, no
new dependencies**. Branch cut from `main` @ `d40ebb9` (after #47). 5
files, +106/−54.

### 1. Professional bag cart icon
The header cart marker was the 🛍 emoji. It's now a stroked boutique-bag
glyph (`BagIcon` in `site-header.tsx`) — rounded 1.6px stroke to match
the contact dock's WhatsApp/phone icon weight, inherits the link's hover
colour, 22px optical size beside the label and count badge.

### 2. Sarees-focused navbar
`Dresses · Kurtis · Lehengas · Dupattas · Accessories` leave the
storefront navigation (header rail **and** footer shop column — same
rule, one helper: `navVisibleCategories()` in
`lib/storefront/queries.ts`).

Scope is navigation only: the categories remain fully intact in the
catalog — data, schema-driven facets, `/category/[slug]` pages and the
spec's future fashion expansion (§4/§61) are untouched. When those lines
launch, removing the slugs from one `Set` returns them to the nav.

### 3. Standard email-based sign-in
`/account/login` led with the magic-link flow and hid the password form
behind a toggle. Now it's the established-sites pattern: **email +
password on one screen → Sign in → inline error**, with the one-time
email link demoted to a clearly-labelled secondary option ("No password
yet? Email me a one-time link") for accounts without a password. Page
copy updated to match. Server actions, the verify route, §46 rate limits
and `next` redirects are all unchanged.

## Verification
- Served HTML: rail renders `Shop all · Sarees · Silk Sarees · Blouses ·
New arrivals · Account` (removed categories absent everywhere, incl.
footer); zero emoji cart markers; login renders the password form first
with `autoComplete="current-password"`.
- Password auth proven end-to-end against live Supabase: HTTP 200 +
session token for `[email protected]`.
- `tsc` clean · eslint (1 pre-existing `main` warning only) · **278/278
unit tests** · production build green.

## Notes for reviewers
- @ManoharPaturi — please review, approve and merge when satisfied;
intentionally left unmerged.
- Preview note: until the Preview env vars from the #47 thread are
toggled, previews show the storefront with the gold setup banner
(expected); the centered nav, bag icon and filtered rail are visible
either way.

This branch was successfully deployed

1 active deployment
Preview — a511976b Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants