Skip to content

fix: tolerate browser-extension attribute injection on html/body (hydration warning) - #43

Merged
ManoharPaturi merged 2 commits into
mainfrom
fix/hydration-extension-tolerance
Oct 18, 2026
Merged

ManoharPaturi merged 2 commits into
mainfrom
fix/hydration-extension-tolerance

Conversation

@Pushpak731

@Pushpak731 Pushpak731 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes the React hydration console error the owner hit while browsing the local site:

A tree hydrated but some attributes of the server rendered HTML didn't match…
<body className="min-h-full flex flex-col font-sans"
-  wotdisconnected="true"

Root cause — not app code. The mismatched attribute is injected into <body> by a browser extension (Web of Trust / WOT) before React hydrates. Reproduced on a clean browser session by injecting exactly that attribute pre-hydration: the identical error fires on the unmodified app; nothing in the codebase writes it.

Change

app/layout.tsx: suppressHydrationWarning on <html> and <body> — the documented React/Next remedy for extension mutation of those two elements (Grammarly, WOT, dark-mode extensions, …). Scope is deliberately narrow:

  • attribute-mismatch tolerance on those two tags only;
  • the app tree's hydration checks remain fully active;
  • no behaviour change (warning is cosmetic; the site worked).

Verification

  • Injected-attribute replay: before → identical console error; after → zero console errors, page renders normally with the attribute still present.
  • Any customer with such an extension benefits too — this was not just the owner's browser.
  • tsc / eslint / 278 tests / production build all green (no other file touched).

Notes for reviewers

…et al.) inject attributes before hydration

Reproduced by injecting wotdisconnected=true on <body> pre-hydration:
identical console error fired before the fix, zero errors after, page
renders normally with the attribute still present. Attribute-only
tolerance on these two elements; app-tree hydration checks unchanged.
Copilot AI balanced review requested due to automatic review settings October 18, 2026 10:13
@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sri-vartali-commerce Ready Ready Preview Oct 18, 2026 10:21am UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Pushpak731

Copy link
Copy Markdown
Contributor Author

@ManoharPaturi — requesting your review, approval and merge for the hydration tolerance fix (1 file, 9 lines).

Context: this is the console error you'll see with the WOT browser extension installed — wotdisconnected="true" lands on <body> before React hydrates. Reproduced on a clean session pre-fix; zero console errors post-fix. Attribute-only tolerance on <html>/<body>; the app tree's hydration checks stay fully active.

Merge order: independent of #42/#44/#45 — any time. 🙏

@ManoharPaturi ManoharPaturi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ManoharPaturi
ManoharPaturi merged commit 98b3d1c into main Oct 18, 2026
4 checks passed
@ManoharPaturi
ManoharPaturi deleted the fix/hydration-extension-tolerance branch October 18, 2026 10:22
Pushpak731 added a commit that referenced this pull request Oct 18, 2026
…Buy-via-WhatsApp on product pages, 1440px layout, logo

Rebased onto main @ 98b3d1c (after #42/#43 squash-merges) to clear the
stacked-branch conflicts — content identical to the original Phase 17
commit; see PR description for the five functions and verification.
ManoharPaturi pushed a commit that referenced this pull request Oct 18, 2026
…Buy-via-WhatsApp on product pages, 1440px layout, logo (#44)

## Summary

Owner-directed UX pass (2026-10-11), five functions, one per owner
request. **Stacked on #42** (this PR's base is
`feat/phase16-whatsapp-first`; it will auto-retarget to `main` once #42
merges — merge #42 first). App code only; **no migration, no new
dependencies**.

### 1. Navbar functionality
- New `components/storefront/header-nav.tsx` (client, `usePathname`):
the category rail **highlights the active route** (bold + underline +
`aria-current="page"`); exact-match for `/shop` and categories,
prefix-match for `/account/*`.
- All remaining rail links audited against live routes — every item
resolves.

### 2. Track Order removed everywhere (§7/§37 v3.1)
- `app/(storefront)/track-order/` deleted (404), header link removed,
sitemap entry dropped, `getTrackOrderView` +
`TrackOrderView`/`TrackOrderResult` deleted from
`lib/orders/queries.ts`, `robots.ts` comment updated.
- Account-order cross-link now points at the shared `/order/<n>` page
(no dead links anywhere — swept the tree).
- Status visibility is unchanged for real users: public order page +
client dashboard + §36 WhatsApp tracking message.

### 3. Buy Now removed everywhere; product pages get Buy via WhatsApp
(§19 v3.1)
- Removed: product-page buttons (inline + sticky bar),
`buyNow`/`abandonBuyNow` actions, the `svs_buy_now` cookie layer,
checkout buy-now mode + banner + `mode` plumbing
(`lib/checkout/types.ts`, `reviewCheckout`, `placeOrderAction`).
- Added: green **Buy via WhatsApp** beside Add to Cart (inline + sticky
mobile bar) built from `buildProductWhatsAppMessage`
(`lib/cart/whatsapp.ts`): prefills product name, Product ID, variant,
**live quantity**, unit price, estimated total. URL rebuilds as the
customer changes qty/variant (verified in-browser: Qty 2 → total
₹5,998).
- Mobile contact dock yields its bottom bar on `/product/*` so the two
never stack.

### 4. Wider layout
- `max-w-6xl` (1152px) → `max-w-[1440px]` across **all shells**
(storefront pages, client dashboard, admin) — 26 files, mechanical sed;
visual gate re-passed at 1680px (no stretching, cards scale cleanly).

### 5. Brand logo
- `public/brand/logo.svg` — SV monogram medallion (wine + zari gold,
placeholder until owner artwork drops in as a file swap). Header
(h-9/h-10, responsive) + footer brand block.

## Verification
- `tsc` clean; eslint — only the 1 pre-existing `params` warning that
`main` already has; **278 tests pass**; production build green.
- Browser e2e: active states verified on `/shop` +
`/category/silk-sarees`; product wa.me deep link (live qty rebuild);
**full checkout re-run post-removal → order `SVS-ORD-20261011-00002`
placed** (order pipeline intact); mobile product page shows exactly one
bottom bar; visual gate pass on home-wide, product-wide, shop-mobile.
- `/track-order` → 404 confirmed.

## Notes for reviewers
- Owner sign-off already given for both removals (Track Order, Buy Now)
— recorded in the spec v3.1 PR (#45) alongside the rewritten §19/§37.
- Sequencing: **#42 → this PR → #45** (#43 is independent).
ManoharPaturi added a commit that referenced this pull request Oct 18, 2026
…viations (#45)

## Summary

`Sri_Vartali_AI_Agent_Build_Spec.md` **v3.0 → v3.1** (192 insertions /
42 deletions): the spec was frozen at Phase 15 while the platform moved
on. This PR brings the plan document in line with what actually ships,
preserving **all 63 section numbers** so every existing `§`
cross-reference (README, `docs/ops` runbooks, code comments) still
resolves.

### What changed
- **Revision History** block (new, after the header): v3.0 vs v3.1
provenance, owner-directed deviations called out explicitly.
- **§2**: the two WhatsApp-first entry points (cart + product deep
links) documented, and why they don't violate rule 9 — they deliberately
create **no** order row.
- **§5**: implementation note — no Radix (custom components cover it),
actual `lib/` layout, WhatsApp runs on wa.me deep links today (Cloud API
built, unconfigured).
- **§7**: routes split live / removed (`/track-order`) / future info
pages.
- **§13/§18/§48**: product-page section list, cart primary CTA, mobile
requirements — updated for Buy via WhatsApp + the contact dock.
- **§19**: rewritten as a REMOVED record — the v3.0 Buy Now plan, and
the replacement's properties (no server state, qty/variant-aware, single
supplier number, hides when unconfigured).
- **§37**: rewritten as a REMOVED record — plus where each old
capability lives now (public order page / client dashboard / §36
tracking message) and the preserved credential discipline.
- **§51**: env-var names aligned with `.env.example` exactly
(`NEXT_PUBLIC_` prefixes + `NEXT_PUBLIC_WHATSAPP_STORE_NUMBER`).
- **§54**: phase log extended **Phase 12 → Phase 17** (super
admin/realtime, facets, acceptance audit, smoke runbook, WhatsApp-first
commerce, owner UX pass).
- **§60**: MVP list annotated (WhatsApp-first handoffs added; Track
Order struck).

## Verification
- Markdown fences balanced (232 — even), section count unchanged,
rendered spot-check of the new header/revision block.
- Docs-only diff — one file, no code, no CI impact beyond the standard
pipeline.

## Notes for reviewers
- Removed features are **documented, not erased** — the spec keeps the
audit trail of what was planned, what shipped, and what the owner
changed, matching this repo's docs discipline.
- Companion code PRs: #42 (Phase 16), #44 (Phase 17), #43 (hydration fix
— unrelated).

Co-authored-by: Manohar Paturi <[email protected]>

This branch was successfully deployed

1 active deployment
Preview — ecc291d8 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants