Repository navigation
test(acp): settle/1 tolerates a peer that stopped between the alive check and the sync - #782
Merged
Merged
Conversation
…z#6088 The PR's single commit was amended with Signed-off-by to satisfy Block's DCO check (83eda69a -> af535a64, identical tree). The old sha is now unreachable from any branch on the fork, so the pin follows it before GitHub can GC it. Co-Authored-By: Claude Fable 5 <[email protected]>
…ock/buzz#6088) Co-Authored-By: Claude Fable 5 <[email protected]>
…heck and the sync
The server stops the peer the moment it reports {:done, _}; :sys.get_state
on it can hit noproc. That is the settled state, not a failure — it flaked
partition 2 on 2026-08-17.
Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake seen on #780's partition 2:
the conversation accepts another prompt afterwards—settle/1readacp_peer, checkedProcess.alive?, and the peer stopped (server stops it on{:done, _}) before:sys.get_state→noproc. A dead peer at that point IS the settled state. Catch the exit. 22/22 locally.🤖 Generated with Claude Code