Skip to content

Skips filtering numeric hypothesis tests - #2723

Merged
IvoDD merged 1 commit into
masterfrom
skip-flaky-hypothesis
Oct 22, 2025
Merged

Skips filtering numeric hypothesis tests#2723
IvoDD merged 1 commit into
masterfrom
skip-flaky-hypothesis

Conversation

@IvoDD

@IvoDD IvoDD commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

numpy v1 has bugs with comparing int64 and uint64 (e.g. numpy/numpy#12525)

Our hypothesis tests were flaking catching these bugs in numpy. Now we skip the tests which do such comparisons if we're using numpy==1.x.

Example failure with numpy==1.24.4 which gets fixed if I upgrade to numpy==2.x:

Original df:
                    a                   b
0  216454270008951536  216454270008951537
with dtypes:
a     int64
b    uint64
dtype: object
query:
WHERE (Column["a"] LT Column["b"])
Pandas result:
Empty DataFrame
Columns: [a, b]
Index: []
ArcticDB result:
                    a                   b
0  216454270008951536  216454270008951537

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@IvoDD
Skips filtering numeric hypothesis tests
b4c5bd7 
numpy v1 has bugs with comparing int64 and uint64 (e.g. numpy/numpy#12525)

Our hypothesis tests were flaking catching these bugs in numpy. Now we
skip the tests which do such comparisons if we're using numpy==1.x
@IvoDD IvoDD added patch Small change, should increase patch version no-release-notes This PR shouldn't be added to release notes. labels Oct 21, 2025
@IvoDD
IvoDD merged commit 46befa4 into master Oct 22, 2025
@IvoDD
IvoDD deleted the skip-flaky-hypothesis branch October 22, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vasil-pashov vasil-pashov vasil-pashov approved these changes
@alexowens90 alexowens90 alexowens90 approved these changes
@poodlewars poodlewars Awaiting requested review from poodlewars

Assignees

No one assigned

Labels

no-release-notes This PR shouldn't be added to release notes. patch Small change, should increase patch version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IvoDD @vasil-pashov @alexowens90