Skip to content

read_batch logs a warning when data is missing #675

Description

@mehertz

Describe the bug

read_batch both returns a DataError (correct) and logs a root-logger error-level warning message with the same contents as the contained exception.

This is very difficult to hide - all error level messages will have to be ignored. As a result, this makes using read_batch speculatively almost impossible.

Steps/Code to Reproduce

In [80]:  res = l.read_batch([ReadRequest('doesnt_exist')])
[2023-07-31 14:16:57.345] [arcticdb] [error] E_NO_SUCH_VERSION Version not found for symbol

In [81]: res
Out[81]: [<arcticdb_ext.version_store.DataError at 0x7f205e786880>]

Note that the bug here is not that the version cannot be found. That is correct.

The bug is the root-logger, error-level log output produced when a DataError is also returned.

Expected Results

In [80]:  res = l.read_batch([ReadRequest('doesnt_exist')])

In [81]: res
Out[81]: [<arcticdb_ext.version_store.DataError at 0x7f205e786880>]

OS, Python Version and ArcticDB Version

All versions

Backend storage used

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions