[SDK] Added reserve for spans array in BatchSpanProcessor. (#2724) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added reserve for spans array in BatchSpanProcessor.
Added reserve for spans array in BatchSpanProcessor.
Helps to allocate the amount of memory needed for number of records so that dynamic memory allocation doesn't happen in the consume method.
.push_back() reallocates memory each time the method is called.
Using .reserve() would avoid memory reallocation as already the memory is allocated.
References:
https://cplusplus.com/reference/vector/vector/push_back/
https://cplusplus.com/reference/vector/vector/reserve/
* Added reserve for spans array in BatchLogProcessor.
Added reserve for spans array in BatchLogProcessor. Same as previously done for BatchSpanProcessor
* Update batch_log_record_processor.cc
* Update batch_span_processor.cc
* Update sdk/src/logs/batch_log_record_processor.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reserve for spans array in BatchSpanProcessor.
Added reserve for spans array in BatchSpanProcessor.
Helps to allocate the amount of memory needed for number of records so that dynamic memory allocation doesn't happen in the consume method.
.push_back() reallocates memory each time the method is called.
Using .reserve() would avoid memory reallocation as already the memory is allocated.
References:
https://cplusplus.com/reference/vector/vector/push_back/
https://cplusplus.com/reference/vector/vector/reserve/
Added reserve for spans array in BatchLogProcessor.
Added reserve for spans array in BatchLogProcessor. Same as previously done for BatchSpanProcessor
Update batch_log_record_processor.cc
Update batch_span_processor.cc
Update sdk/src/logs/batch_log_record_processor.cc
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes