Skip to content

Add variance vars to CNV HMM#83

Merged
alimanfoo merged 2 commits intomalariagen:masterfrom
leehart:add-variance-vars-to-CNV-HMM
Nov 25, 2021
Merged

Add variance vars to CNV HMM#83
alimanfoo merged 2 commits intomalariagen:masterfrom
leehart:add-variance-vars-to-CNV-HMM

Conversation

@leehart
Copy link
Copy Markdown
Collaborator

@leehart leehart commented Nov 17, 2021

Ref #1540

@alimanfoo
Copy link
Copy Markdown
Member

Hi @leehart, just to say this looks spot on, I guess it's failing CI as the data are in the release bucket yet. Happy to approve this now and then you can merge when data are in place and CI is passing?

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Nov 17, 2021

Hi @leehart, just to say this looks spot on, I guess it's failing CI as the data are in the release bucket yet. Happy to approve this now and then you can merge when data are in place and CI is passing?

I expect so. I was hoping to figure out a way to test & pass while still in the staging bucket, but I suspect that's overkill.

@leehart leehart requested a review from alimanfoo November 17, 2021 19:36
@leehart leehart marked this pull request as ready for review November 17, 2021 19:36
@leehart leehart marked this pull request as draft November 17, 2021 19:38
@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Nov 23, 2021

@alimanfoo CI checks are still failing despite the new data being in the release bucket. Investigating.

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Nov 23, 2021

The failed tests seem to pass locally, so I'm starting to wonder if this is a caching issue again, but I'm not completely sure what the tests are doing yet.

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Nov 23, 2021

I tried rerunning the CI checks after an hour but got the same result, so if it is a caching issue it seems different or longer lasting than the consolidated Zarr metadata one.

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Nov 24, 2021

@alimanfoo CI checks passed after reconsolidating the recently released CNV data, including tests for test_cnv_discordant_read_calls

@leehart leehart marked this pull request as ready for review November 24, 2021 11:16
Copy link
Copy Markdown
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lee, going to merge.

@alimanfoo alimanfoo merged commit eb27660 into malariagen:master Nov 25, 2021
@leehart leehart deleted the add-variance-vars-to-CNV-HMM branch November 25, 2021 09:40
@alimanfoo alimanfoo added this to the v1.0.0 milestone Dec 15, 2021
@alimanfoo alimanfoo added the BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants