Add variance vars to CNV HMM#83
Add variance vars to CNV HMM#83alimanfoo merged 2 commits intomalariagen:masterfrom leehart:add-variance-vars-to-CNV-HMM
Conversation
|
Hi @leehart, just to say this looks spot on, I guess it's failing CI as the data are in the release bucket yet. Happy to approve this now and then you can merge when data are in place and CI is passing? |
I expect so. I was hoping to figure out a way to test & pass while still in the staging bucket, but I suspect that's overkill. |
|
@alimanfoo CI checks are still failing despite the new data being in the release bucket. Investigating. |
|
The failed tests seem to pass locally, so I'm starting to wonder if this is a caching issue again, but I'm not completely sure what the tests are doing yet. |
|
I tried rerunning the CI checks after an hour but got the same result, so if it is a caching issue it seems different or longer lasting than the consolidated Zarr metadata one. |
|
@alimanfoo CI checks passed after reconsolidating the recently released CNV data, including tests for |
alimanfoo
left a comment
There was a problem hiding this comment.
Thanks Lee, going to merge.
Ref #1540