Conversation
ahernank
reviewed
Apr 16, 2025
Collaborator
ahernank
left a comment
ahernank
left a comment
There was a problem hiding this comment.
Thanks @eselimnl, looks good. If we merge & release here, as the S3 bucket is public, all Pf8 data will be available by default through the API. As you know, this is not currently the case, as the GCS bucket is private at the moment. Can I double check this the expected behaviour that you & @podpearson want now?
Collaborator
|
Hi @ahernank - can confirm we are happy to have Pf8 data available now. |
Member
|
Yes, agreed, happy to have Pf8 data available now. Many thanks @ahernank ! |
ahernank
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Pf8 data objects are currently stored in both Google Cloud Storage (GCS) and Sanger S3. Based on a recent cost analysis, S3 has been identified as the more cost-effective option. As a result, this PR attempts to update Pf8()'s default URL to point to S3.
Cheers, Eyyub