IGV access after authentication requirement for master#752
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ahernank
left a comment
ahernank
left a comment
There was a problem hiding this comment.
Thanks @jonbrenas! Wonder if this would be a bit clearer if we define the public URL in the same way as the other GCS URLs, e.g.GCS_DEFAULT_URL = "gs://vo_agam_release_master_us_central1/ in ag3.py (& equivalent in af1), i.e. globally defined & linking directly to the gsutil file path rather than the public URL (unless this is causing issues with IGV?)
…ata-python into GH737-IGV-access
|
Thanks @ahernank. I updated the URL and created a variable containing it. My first attempts at using a GCS URL had failed but it looks like it was due to a typo. I don't know if we want to do something similar to what was done for There seems to be an unrelated issue with linting, though. |
|
Approving as just a small change moving the assignment is required. |
|
Actually, decided to keep as-is with the caveat this could create confusion as the public ref only is relevant for IGV. |
2 participants
Addresses #737.
Most of the changes were actually to gcs. I added a new parameter (
public_url) to the AnophelesBase class which is currently initialised with a hard-coded value. It should be set from the config file but I didn't want to modify the contig without some degree of approval first.The notebook seemed to show that it works for both agam and afun but the tests will show if it is really the case, I guess.