Merged
Conversation
Collaborator
Author
|
Linting fails for a different reason here, using Bokeh 3.6.3 and Dash 3.0.0 The relevant code in app.layout = html.Div(
[
html.Div(
cytoscape_component,
className="nine columns",
style={
# required to get cytoscape component to show ...
# reduce to prevent scroll overflow
"height": f"{height - 50}px",
"border": "1px solid black",
},
),
html.Div(
legend_component,
className="three columns",
style={
"height": f"{height - 50}px",
},
),
html.Div(id="output"),
],
) |
Collaborator
Author
|
Maybe related issue logged recently for Dash plotly/dash#3226 I'm not sure how to upgrade this code to satisfy Dash 3.0.0 yet, and we know 2.18.2 works, so I'm tempted to temporarily restrict us to <3.0.0. |
jonbrenas
approved these changes
Mar 21, 2025
Collaborator
jonbrenas
left a comment
There was a problem hiding this comment.
Seems sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: issue #734