Skip to content

Resolve CI linting failures#740

Merged
leehart merged 2 commits intomasterfrom
GH734_fix_linting_test_failures
Mar 21, 2025
Merged

Resolve CI linting failures#740
leehart merged 2 commits intomasterfrom
GH734_fix_linting_test_failures

Conversation

@leehart
Copy link
Copy Markdown
Collaborator

@leehart leehart commented Mar 21, 2025

Re: issue #734

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Mar 21, 2025

Linting fails for a different reason here, using Bokeh 3.6.3 and Dash 3.0.0

malariagen_data/anopheles.py:2389: error: Property "layout" defined in "Dash" is read-only  [misc]
Found 1 error in 1 file (checked 94 source files)

The relevant code in anopheles.py currently looks like this:

        app.layout = html.Div(
            [
                html.Div(
                    cytoscape_component,
                    className="nine columns",
                    style={
                        # required to get cytoscape component to show ...
                        # reduce to prevent scroll overflow
                        "height": f"{height - 50}px",
                        "border": "1px solid black",
                    },
                ),
                html.Div(
                    legend_component,
                    className="three columns",
                    style={
                        "height": f"{height - 50}px",
                    },
                ),
                html.Div(id="output"),
            ],
        )

@leehart
Copy link
Copy Markdown
Collaborator Author

leehart commented Mar 21, 2025

Maybe related issue logged recently for Dash plotly/dash#3226

I'm not sure how to upgrade this code to satisfy Dash 3.0.0 yet, and we know 2.18.2 works, so I'm tempted to temporarily restrict us to <3.0.0.

@leehart leehart changed the title Updated pyproject.toml and poetry.lock to exclude Bokeh 3.7.0 Resolve CI linting failures Mar 21, 2025
@leehart leehart marked this pull request as ready for review March 21, 2025 14:27
Copy link
Copy Markdown
Collaborator

@jonbrenas jonbrenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me.

@leehart leehart merged commit bc8bf72 into master Mar 21, 2025
10 checks passed
@leehart leehart deleted the GH734_fix_linting_test_failures branch March 21, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants