Conversation
|
The tests for the plotting functions are still only on SNP frequencies. Is that good enough? |
|
@alimanfoo, I might have found a solution that works for what I wanted to do (namely, import shared testing functions for plotting frequencies into the various |
alimanfoo
left a comment
There was a problem hiding this comment.
Hi @jonbrenas, thanks so much. A few comments...
Thanks @jonbrenas. As suggested in the code review above, it might be even better to name these utility functions like "check_..." instead of "test_..." then no need for skipping. If the importing of functions between test modules seems to work then I guess we're OK! I still don't understand the mechanics of how pytest imports test modules. But if you've confirmed it works then no objection. |
|
Thanks @alimanfoo. This all makes a lot of sense. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 94.57% 94.96% +0.39%
==========================================
Files 40 45 +5
Lines 4187 4612 +425
==========================================
+ Hits 3960 4380 +420
- Misses 227 232 +5 ☔ View full report in Codecov by Sentry. |
leehart
left a comment
There was a problem hiding this comment.
Thanks @jonbrenas . This looks good to go, unless you know of any further changes required?
_frequencies functionsfrq_base.py
Addresses #664 .
I moved the functions to enable the computation of frequencies and the plotting functions (which required to define a new
AnophelesFrequencyclass). I still want to move the tests of the plotting functions to their own file instead oftest_snp_frq.py.