Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Here is a picture of what it looks like

Looks good!

Thanks @alimanfoo . I have set the palette for plot_cnv_hmm_heatmap() to be the same. However, it is hard-coded and I think it would be better to offer users the option to choose their own palette (as is the case for plot_diplotype_clustering_advanced) so I will add palette to the parameters.

Thanks @alimanfoo . I have set the palette for plot_cnv_hmm_heatmap() to be the same. However, it is hard-coded and I think it would be better to offer users the option to choose their own palette (as is the case for plot_diplotype_clustering_advanced) so I will add palette to the parameters.

Thanks @jonbrenas, good call.

@jonbrenas Pylint is telling me that it's "dangerous" to have a mutable list as a default value for an argument, so we might want to remedy this at some point.
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/dangerous-default-value.html

Thanks @leehart. Is Python's policy that all parameters should be tuples then?

Hi @jonbrenas - I'm not sure yet what we should be doing instead, if anything, since this is just a warning from a linter, but I've logged a new issue to "put a pin in it" #787

Further reading:

• https://www.pullrequest.com/blog/python-pitfalls-the-perils-of-using-lists-and-dicts-as-default-arguments/
• https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
• https://www.pythonmorsels.com/mutable-default-arguments/