Skip to content

Adds cohort access to SNP and CNV frequency methods#61

Merged
cclarkson merged 10 commits intomasterfrom
1509-cc-57-snpfreq
Sep 28, 2021
Merged

Adds cohort access to SNP and CNV frequency methods#61
cclarkson merged 10 commits intomasterfrom
1509-cc-57-snpfreq

Conversation

@cclarkson
Copy link
Copy Markdown
Collaborator

resolves #57, #58

@cclarkson cclarkson requested a review from alimanfoo September 24, 2021 18:18
Copy link
Copy Markdown
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chris, looking good.

A few small suggestions in the implementation.

On the testing side, re when to use pytest.parametrize the key question is whether it means you can avoid duplicating testing code. I.e., you should be able to run at least some code under all values of the variables you are parametrizing, other there is no point and witchery is right you're better off to break up into separate functions. I think this applies to the test_snp_allele_frequencies() function.

Re test_gene_cnv_frequencies() there's a couple of things could be tightened up. More than happy to discuss or do paired if not immediately obvious.

Copy link
Copy Markdown
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💐

@cclarkson cclarkson merged commit 00c053c into master Sep 28, 2021
@leehart leehart deleted the 1509-cc-57-snpfreq branch December 2, 2024 15:46
@alimanfoo alimanfoo added the BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cohort access to Ag3.snp_allele_frequencies

2 participants