Adds cohort access to SNP and CNV frequency methods#61
Merged
Conversation
alimanfoo
reviewed
Sep 27, 2021
Member
alimanfoo
left a comment
There was a problem hiding this comment.
Hi Chris, looking good.
A few small suggestions in the implementation.
On the testing side, re when to use pytest.parametrize the key question is whether it means you can avoid duplicating testing code. I.e., you should be able to run at least some code under all values of the variables you are parametrizing, other there is no point and witchery is right you're better off to break up into separate functions. I think this applies to the test_snp_allele_frequencies() function.
Re test_gene_cnv_frequencies() there's a couple of things could be tightened up. More than happy to discuss or do paired if not immediately obvious.
This was referenced Sep 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #57, #58