Conversation
…s, avoids using dask
…variant_allele mapping
Removed numba decorator for the apply_allele_mapping function, for now
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
… check that dimensions and contect of exported dummy data are correct
|
Tristan has included a notebook in his PR to test the PLINK converter functions. The main issue is that it creates a .bed file which raises issues with correct paths (there also seems to be a problem with authentication when he ran it locally but that’s neither here nor there). I think the best solution is to stop tracking the notebook. @alimanfoo, @ahernank, @cclarkson, @leehart, any opinion? |
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
|
Hi guys, I fixed the test notebook and the local tests are now completing successfully |
|
Thanks @tristanpwdennis, unit tests are now passing :) Looks like the plink_convert notebook also needs to be updated though to use "output_dir" instead of "results_dir". |
|
Whoops, sorry, please blame the psychotropic jetlag. Fixed this now, and updated the output path to be the working dir of the notebook (as opposed to a relative path on my local!). Hope this is OK? |
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
Co-authored-by: Alistair Miles <[email protected]>
…to plink-converter-2024-03-26-tristanpwdennis-shadow
…ithub.com:malariagen/malariagen-data-python into plink-converter-2024-03-26-tristanpwdennis-shadow
jonbrenas
left a comment
There was a problem hiding this comment.
LGTM and approved by @alimanfoo here: #515
This PR shadows #515 to get GitHub actions running.