Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
==========================================
+ Coverage 98.49% 98.59% +0.10%
==========================================
Files 30 31 +1
Lines 2520 2996 +476
==========================================
+ Hits 2482 2954 +472
- Misses 38 42 +4 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Alright, think I'm just about done here. Planning to merge if CI looks good. |
alimanfoo
added
the
BMGF-001927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on the journey towards #366 here we refactor functions related to SNP allele frequencies analysis.
Also fix a bug in
aa_allele_frequencies()where frequencies would be reported as 0 even where all genotypes are missing, should be nan instead.