Skip to content

Anopheles refactor part 7 - AIM genotype data#405

Merged
alimanfoo merged 14 commits intomalariagen:masterfrom
alimanfoo:anopheles-refactor-aim-data-2023-05-24
Jun 10, 2023
Merged

Anopheles refactor part 7 - AIM genotype data#405
alimanfoo merged 14 commits intomalariagen:masterfrom
alimanfoo:anopheles-refactor-aim-data-2023-05-24

Conversation

@alimanfoo
Copy link
Copy Markdown
Member

@alimanfoo alimanfoo commented May 28, 2023 •
edited
Loading

Continue working towards #366 here tackling the AIM genotype data access and plotting functions.

Also resolves #392 along the way.

Work plan:

  • Refactor code into new aim_data and aim_params sub-modules.
  • Refactor tests and run against simulated data.

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app bot commented May 28, 2023

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

This was referenced May 28, 2023
Closed
Open
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.41%. Comparing base (2d10548) to head (9530d8f).
Report is 591 commits behind head on master.

Files with missing lines Patch % Lines
malariagen_data/anoph/aim_data.py 97.27% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   96.33%   96.41%   +0.07%     
==========================================
  Files          21       23       +2     
  Lines        1528     1644     +116     
==========================================
+ Hits         1472     1585     +113     
- Misses         56       59       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alimanfoo alimanfoo marked this pull request as ready for review June 10, 2023 20:43
@alimanfoo alimanfoo merged commit aea9c90 into malariagen:master Jun 10, 2023
@alimanfoo alimanfoo deleted the anopheles-refactor-aim-data-2023-05-24 branch June 10, 2023 21:35
@alimanfoo alimanfoo added the BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider using relative path in Ag3.aim_calls()

1 participant

@alimanfoo