Faster xarray concatenation#395
Merged
alimanfoo merged 5 commits intomalariagen:masterfrom May 11, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 4 4
Lines 689 689
=======================================
Hits 660 660
Misses 29 29 ☔ View full report in Codecov by Sentry. |
15 tasks
alimanfoo
added
the
BMGF-001927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is something funny going on within the xarray concat() function which is causing a big slowdown when we try to concatenate datasets, such as the datasets that are being concatenated internally within the snp_calls() or haplotypes() functions. A lot of time is being spent within this list comprehension in particular and the logic of it doesn't look right (pathological for large dimensions?).
In the mean time, this PR hacks a cut down version of concatenating datasets along a dimension, which is much much faster (like 1000X).