Skip to content

snp_allele_frequencies() Pandas Warning - fragmented dataframe#110

Merged
alimanfoo merged 2 commits intomasterfrom
108-performance-warning
Dec 23, 2021
Merged

snp_allele_frequencies() Pandas Warning - fragmented dataframe#110
alimanfoo merged 2 commits intomasterfrom
108-performance-warning

Conversation

@cclarkson
Copy link
Copy Markdown
Collaborator

@cclarkson cclarkson commented Dec 20, 2021

resolves #108

Uses a dictionary of columns and pandas.concat([df, dict], axis=1) rather than df[name] = newcolumn to avoid dataframe fragmentation warning.

@cclarkson cclarkson changed the title WIP snp_allele_frequencies() Pandas Warning - fragmented dataframe snp_allele_frequencies() Pandas Warning - fragmented dataframe Dec 21, 2021
@cclarkson
Copy link
Copy Markdown
Collaborator Author

Hi @alimanfoo, this should get rid of the fragmentation warning.

@alimanfoo alimanfoo added this to the v1.0.0 milestone Dec 23, 2021
@alimanfoo alimanfoo merged commit ac7d483 into master Dec 23, 2021
@alimanfoo alimanfoo deleted the 108-performance-warning branch December 23, 2021 22:08
@alimanfoo
Copy link
Copy Markdown
Member

Thanks Chris 🌸

@alimanfoo alimanfoo added the BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BMGF-001927 Work supported by BMGF grant INV-001927 (MalariaGEN 2019-2024).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ag3.snp_allele_frequencies() still causing "PerformanceWarning: DataFrame is highly fragmented"

2 participants