Skip to content

Spectrum v1.2.0#19

Merged
majockbim merged 65 commits into
majockbim:mainfrom
johnmilson125-png:main
May 25, 2026
Merged

Spectrum v1.2.0#19
majockbim merged 65 commits into
majockbim:mainfrom
johnmilson125-png:main

Conversation

@johnmilson125-png

@johnmilson125-png johnmilson125-png commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Screenshot 2026-05-04 212450

This pull request includes:

Program Optimization:

  • Improved resizing
  • Improved color display
  • App has been made customizable.
  • Added new menu (decided to delete it soon)
  • Added settings
  • Added themes

Code Optimization:

  • Code Improved and checked

Theme Modes:

const struct ThemeModeManager themeModeManager[] = {
    {"Default Mode", ThemeMode::Mode0},
    {"Mode 1", ThemeMode::Mode1},
    {"Mode 2", ThemeMode::Mode2},
    {"Mode 3", ThemeMode::Mode3},
    {"Mode 4", ThemeMode::Mode4}
};

ThemeMode::Mode0 or Default Mode:
Screenshot 2026-05-04 231212

ThemeMode::Mode1 or Mode 1 (temporary names):
Screenshot 2026-05-06 163316

ThemeMode::Mode2 or Mode 2 (temporary names):
Screenshot 2026-05-06 163501

ThemeMode::Mode3 or Mode 3 (temporary names):
Screenshot 2026-05-06 164115

ThemeMode::Mode4 or Mode 4 (temporary names):
Screenshot 2026-05-07 114021

@majockbim majockbim added enhancement New feature or request v.1.2.0 documentation Improvements or additions to documentation labels May 5, 2026
@majockbim majockbim self-requested a review May 5, 2026 11:53
@majockbim

majockbim commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

So far the PR looks awesome, the logo and config system are exactly what i had in mind.

Before moving on I had some requests:

  • 1. Merge Conflicts

    • The merge conflicts are because this was built on top of v1.0.0 before v1.1.0 was pulled, can you pull from main and resolve the conflicts?

  • 2. JSON Parser

    • For the JSON finder, i think looking for any .json in the directory is a bit risky/unsafe, if a user has an unrelated package.json or data.json in the same folder it could cause issues. Can we change it to look for a specifically named file (spectrum.json) instead?

  • 3. Example Config File

    • Could you include an example spectrum.json in the PR with all the available options and a short comment explaining what each one does? Just something users can drop into the same folder as the .exe and tweak. This would also make it much easier to document in the README.

  • 4. Documentation

    • Please include a GNU license header in the settings.cpp and settings.hpp.
    • You can copy the text straight from the v1.2.0 visualizer.cpp!

other than that this is genuinely great work, excited to get these changes merged!

Side Note:

  • Once the 3 points above are covered, I'll personally start working on v1.2.0 - on things like documentation, tweaks & changes, etc..

majockbim
majockbim requested changes May 5, 2026
View reviewed changes

@majockbim majockbim left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the comment I left on the PR for more detail on the requested changes.

Todo:

  • Resolve merge conflicts
  • Update JSON parser
  • Add example spectrum.json file
  • GNU documentation update

@johnmilson125-png

johnmilson125-png commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

well, let's talk about your notices!:

  • Documentation

    • i'll start by adding GNU License on every file i create.

  • Settings and JSON Finder

    • about settings.json and JSON Finder, i'll leave it as it is, but i'll make it finding themes and let the user choose one of these themes, and add specific settings file settings.json contains general settings of the program.

  • Conflicts

    • about conflicts, yeah, i will resolve them!.

@majockbim

majockbim commented May 5, 2026

Copy link
Copy Markdown
Owner

Sounds good!

@majockbim

majockbim commented May 24, 2026

Copy link
Copy Markdown
Owner
themes.-.mp4

The bottom terminal reflects the most recent changes + the theme examples expected to be in the release folder :p

@majockbim

majockbim commented May 24, 2026

Copy link
Copy Markdown
Owner

v1.2.0 is complete! I'll release tommorow

majockbim added a commit that referenced this pull request May 24, 2026
@majockbim
docs: use FFmpeg for GIF transparency (#19)
3a847c9 
Replaced the v1.2.0 release GIF image with a transparent version.
@majockbim majockbim changed the title Spectrum v1.2.000000c1 Spectrum v1.2.0 May 25, 2026
@majockbim majockbim self-assigned this May 25, 2026
@majockbim majockbim self-requested a review May 25, 2026 01:42
@majockbim majockbim merged commit b53764c into majockbim:main May 25, 2026
majockbim added a commit that referenced this pull request May 25, 2026
@majockbim
release v1.2.0 (#19)
b75c4af 
thank you to the contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majockbim majockbim majockbim approved these changes

Assignees

@majockbim majockbim

@johnmilson125-png johnmilson125-png

Labels

documentation Improvements or additions to documentation enhancement New feature or request v.1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnmilson125-png @majockbim