disable cosmetic typar overwrite in type extensions

majocha · majocha · commit 15fbf8fab5f3 · 2025-10-29T12:31:42.000+01:00
it needs to be made compatible with parallel checking
diff --git a/src/Compiler/Checking/CheckDeclarations.fs b/src/Compiler/Checking/CheckDeclarations.fs
@@ -4218,18 +4218,20 @@ module TcDeclarations =
                 | Result res ->
                     // Update resolved type parameters with the names from the source.
                     let _, tcref, _ = res
+
+                    // Disabled to allow deterministic parallel type checking. See https://github.com/dotnet/fsharp/issues/19033
+                    // TODO: mutating typar here can lead to a race during parallel type checking.
+                    // Some type extensions can end up with a wrong type argument name.
+                    // This will break deterministic builds.
                    
-                    if tcref.TyparsNoRange.Length = synTypars.Length then
-                        (tcref.TyparsNoRange, synTypars)
-                        ||> List.zip
-                        |> List.iter (fun (typar, SynTyparDecl.SynTyparDecl (typar = tp)) ->
-                            let (SynTypar(ident = untypedIdent; staticReq = sr)) = tp
-                            if typar.StaticReq = sr then
-                                // TODO: mutating typar here can lead to a race during parallel type checking.
-                                // Some type extensions can end up with a wrong type argument name.
-                                // This will break deterministic builds.
-                                typar.SetIdent(untypedIdent)
-                        )
+                    //if tcref.TyparsNoRange.Length = synTypars.Length then
+                    //    (tcref.TyparsNoRange, synTypars)
+                    //    ||> List.zip
+                    //    |> List.iter (fun (typar, SynTyparDecl.SynTyparDecl (typar = tp)) ->
+                    //        let (SynTypar(ident = untypedIdent; staticReq = sr)) = tp
+                    //        if typar.StaticReq = sr then
+                    //            typar.SetIdent(untypedIdent)
+                    //    )
 
                     tcref
 
diff --git a/src/Compiler/SyntaxTree/UnicodeLexing.fs b/src/Compiler/SyntaxTree/UnicodeLexing.fs
@@ -8,7 +8,7 @@ open Internal.Utilities.Text.Lexing
 
 type Lexbuf = LexBuffer<char>
 
-type LexBuffer<'Char> with
+type LexBuffer<'char> with
 
     member lexbuf.GetLocalData<'T when 'T: not null>(key: string, initializer) =
         match lexbuf.BufferLocalStore.TryGetValue key with
diff --git a/src/Compiler/SyntaxTree/UnicodeLexing.fsi b/src/Compiler/SyntaxTree/UnicodeLexing.fsi
@@ -9,7 +9,7 @@ open Internal.Utilities.Text.Lexing
 
 type Lexbuf = LexBuffer<char>
 
-type LexBuffer<'Char> with
+type LexBuffer<'char> with
     member GetLocalData<'T when 'T: not null> : key: string * initializer: (unit -> 'T) -> 'T
     member TryGetLocalData<'T when 'T: not null> : key: string -> 'T option
 
diff --git a/tests/FSharp.Compiler.ComponentTests/Signatures/TypeTests.fs b/tests/FSharp.Compiler.ComponentTests/Signatures/TypeTests.fs
@@ -76,7 +76,8 @@ namespace Foo.Types
 
     val EndColumn: int"""
 
-[<Fact>]
+// See https://github.com/dotnet/fsharp/issues/19033
+[<Fact(Skip="needs fixing")>]
 let ``Type extension uses type parameters names from source`` () =
     FSharp """
 module Extensions
@@ -93,7 +94,8 @@ type List<'E> with
 
   member X: 'E"""
 
-[<Fact>]
+// See https://github.com/dotnet/fsharp/issues/19033
+[<Fact(Skip="needs fixing")>]
 let ``Type extension with constraints uses type parameters names from source`` () =
     FSharp """
 module Extensions
@@ -110,7 +112,8 @@ type Map<'K,'V when 'K: comparison> with
 
   member X: t: 'T -> k: 'K -> 'K option * ({| n: 'K array |} * int) when 'K: comparison"""
  
-[<Fact>]
+// See https://github.com/dotnet/fsharp/issues/19033
+[<Fact(Skip="needs fixing")>]
 let ``Type extension with lowercase type parameters names from source`` () =
     FSharp """
 module Extensions
