Skip to content

MAISTRA-2648: WASM fix for s390x [maistra-2.2]#139

Merged
maistra-bot merged 1 commit intomaistra:maistra-2.2from
knm3000:wasm-on-s390x-2.2
Mar 17, 2022
Merged

MAISTRA-2648: WASM fix for s390x [maistra-2.2]#139
maistra-bot merged 1 commit intomaistra:maistra-2.2from
knm3000:wasm-on-s390x-2.2

Conversation

@knm3000
Copy link
Copy Markdown
Contributor

@knm3000 knm3000 commented Mar 10, 2022

@maistra-bot
Copy link
Copy Markdown

maistra-bot commented Mar 10, 2022

Hi @knm3000. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knm3000 knm3000 changed the title MAISTRA-2648: WASM fix for s390x MAISTRA-2648: WASM fix for s390x [maistra-2.2] Mar 10, 2022
@oschaaf oschaaf requested review from jwendell and twghu March 10, 2022 22:05
oschaaf
oschaaf approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but deferring to @twghu and @jwendell for final review to avoid collisions with any in-flight work they might have. Therefore I added the do-not-merge/hold label to avoid auto-merge upon this approval.

@twghu
Copy link
Copy Markdown
Contributor

twghu commented Mar 14, 2022

This fix stops an existing test failing on s390x https://github.com/maistra/header-append-filter/blob/maistra-2.2/tests/run-envoy.sh#L34

@maistra-bot maistra-bot merged commit e5f9fab into maistra:maistra-2.2 Mar 17, 2022
oschaaf pushed a commit to oschaaf/envoy-maistra that referenced this pull request Mar 28, 2022
Revert "MAISTRA-2648: WASM fix for s390x (maistra#139)"
88dded3 
This reverts commit e5f9fab.

Signed-off-by: Otto van der Schaaf <[email protected]>
maistra-bot pushed a commit that referenced this pull request Mar 28, 2022
Revert "MAISTRA-2648: WASM fix for s390x (#139)" (#149)
d5e17b5 
This reverts commit e5f9fab.

Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf pushed a commit to oschaaf/envoy-maistra that referenced this pull request Apr 11, 2022
Revert "Revert "MAISTRA-2648: WASM fix for s390x (maistra#139)" (mais…
def52e1 
…tra#149)"

This reverts commit d5e17b5.

Signed-off-by: Otto van der Schaaf <[email protected]>
@knm3000 knm3000 deleted the wasm-on-s390x-2.2 branch June 2, 2022 12:30
dcillera pushed a commit to dcillera/envoy that referenced this pull request Feb 19, 2024
@knm3000 @dcillera
MAISTRA-2648: WASM fix for s390x (maistra#139)
4d28df2 
Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198

Signed-off-by: Konstantin Maksimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwendell jwendell jwendell approved these changes

@twghu twghu twghu approved these changes

+1 more reviewer

@oschaaf oschaaf oschaaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test okay to merge size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@knm3000 @maistra-bot @twghu @jwendell @oschaaf