'Set' headers instead of 'Add' to prevent duplicate header fields#1
Merged
ian-kent merged 1 commit intomailhog:masterfrom May 20, 2015
Merged
'Set' headers instead of 'Add' to prevent duplicate header fields#1ian-kent merged 1 commit intomailhog:masterfrom
ian-kent merged 1 commit intomailhog:masterfrom
Conversation
Member
|
awesome, thanks 👍 |
ian-kent
added a commit
that referenced
this pull request
May 20, 2015
'Set' headers instead of 'Add' to prevent duplicate header fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes mailhog/MailHog#49
For several headers that have to be unique 'Set' should be used instead of 'Add'.
I had to change the control flow in 195ff to filter the header names and act accordingly.