Optimise the Dockerfile for Docker Hub Automated Builds.#118
Merged
ian-kent merged 1 commit intomailhog:masterfrom Nov 14, 2016
Merged
Optimise the Dockerfile for Docker Hub Automated Builds.#118ian-kent merged 1 commit intomailhog:masterfrom
ian-kent merged 1 commit intomailhog:masterfrom
Conversation
Installs ca-certificates, required for the "release message" feature. With the current [mailhog/mailhog](https://hub.docker.com/r/mailhog/mailhog/) docker image, releasing messages to an SMTP server via TLS fails: > Failed to release message: x509: failed to load system roots and no roots > provided Removes any build dependencies after install, optimising docker image size. The image size is about the same as the Rocker based build, but works with plain Docker and can therefore be used via Docker Hub Automated Builds. Runs with a non-privileged user account instead of as root, increasing security. Assigning the user ID 1000 allows host volume mounts (e.g. for maildir storage) to work seamlessly with docker-machine. Installs MailHog in `/usr/local/bin`, which is in the system `PATH` and allows to use a simplified entrypoint (`MailHog`).
Member
|
I like it 👍 thanks @blueimp |
Contributor
Author
|
Thanks for merging! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs ca-certificates, required for the "release message" feature.
With the current mailhog/mailhog docker image, releasing messages to an SMTP server via TLS fails:
Removes any build dependencies after install, optimising docker image size.
The image size is about the same as the Rocker based build, but works with plain Docker and can therefore be used via Docker Hub Automated Builds.
Runs with a non-privileged user account instead of as root, increasing security.
Assigning the user ID 1000 allows host volume mounts (e.g. for maildir storage) to work seamlessly with docker-machine.
Installs MailHog in
/usr/local/bin, which is in the systemPATHand allows to use a simplified entrypoint (MailHog).