Skip to content

Update the svg that we use in our menu item #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikrampm1 merged 1 commit into from
Oct 10, 2024
Merged

Update the svg that we use in our menu item #65

vikrampm1 merged 1 commit into from
Oct 10, 2024

Conversation

@dkotter
Copy link
Collaborator

@dkotter dkotter commented Sep 30, 2024 •
edited by vikrampm1
Loading

Description of the Change

As reported in #63, the svg used in the Mailchimp menu is the wrong one (basically the colors were inverted). This PR fixes that.

Before:

menu svg before

After:

menu svg after

Closes #63

How to test the Change

  1. Check out these changes
  2. View the icon that shows in the left-hand sidebar and ensure it looks correct

Changelog Entry

Changed - Updated the menu SVG icon.

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 1.7.0 milestone Sep 30, 2024
@dkotter dkotter self-assigned this Sep 30, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 30, 2024
@dkotter dkotter requested a review from jeffpaul September 30, 2024 18:53
@qasumitbagthariya
Copy link
Collaborator

qasumitbagthariya commented Oct 9, 2024

Regression / Smoke Test Report ✅

I have verified this PR in the smoke-test branch and looks good to me.

image

Testing Environment

  • WordPress: 6.6.2
  • Theme: Twenty Twenty-Four 1.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 modified the milestones: 1.7.0, 1.6.1 Oct 10, 2024
@vikrampm1 vikrampm1 merged commit 9498f21 into develop Oct 10, 2024
@vikrampm1 vikrampm1 mentioned this pull request Oct 10, 2024
Closed
22 tasks
@dkotter dkotter deleted the fix/63 branch October 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@dkotter dkotter

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.6.1

Development

Successfully merging this pull request may close these issues.

Update menu icon

5 participants

@dkotter @qasumitbagthariya @jeffpaul @vikrampm1