Skip to content

Conversation

@iamdharmesh
Copy link
Collaborator

@iamdharmesh iamdharmesh commented Aug 8, 2024

Description of the Change

PR adds some new end-to-end tests for the plugin based on the critical flow wiki.

How to test the Change

Make sure tests running properly and passing in local or in GH action.

Changelog Entry

Added - Initial E2E tests and coverage of the new OAuth connection flows.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.7.0 milestone Aug 8, 2024
@jeffpaul jeffpaul requested a review from dkotter August 8, 2024 13:51
@iamdharmesh iamdharmesh changed the base branch from enhancement/9 to develop August 8, 2024 14:32
@github-actions github-actions bot removed the request for review from dkotter August 8, 2024 14:32
@iamdharmesh iamdharmesh changed the base branch from develop to enhancement/9 August 9, 2024 10:40
@iamdharmesh iamdharmesh marked this pull request as ready for review August 9, 2024 10:40
@iamdharmesh iamdharmesh requested a review from dkotter August 9, 2024 10:40
@dkotter dkotter merged commit 8cb0929 into enhancement/9 Aug 12, 2024
@dkotter dkotter modified the milestones: 1.7.0, 1.6.0 Aug 12, 2024
@dkotter dkotter deleted the enhancement/e2e-tests branch August 12, 2024 20:49
@dkotter
Copy link
Collaborator

dkotter commented Sep 24, 2024

@iamdharmesh E2E tests are failing now and I think it's due to the environment variables no longer existing (like Cypress.env('MAILCHIMP_USERNAME') as an example). I don't recall how we set those previously, are those variables stored at the GitHub level that maybe got removed?

@iamdharmesh
Copy link
Collaborator Author

@dkotter, I can see the environment variables on the list. However, if you are talking about E2E tests failing in recent PRs from dependabot then it's due to repo secrets are not available for PR raised by bot or from the forked repo. So, this is expected (I am not sure on how we can make repo secrets available to the Dependabot PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants