Skip to content

Updates translations to use .org GlotPress #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkotter merged 2 commits into from
Jun 28, 2024
Merged

Updates translations to use .org GlotPress #39

dkotter merged 2 commits into from
Jun 28, 2024

Conversation

@noraconley
Copy link
Collaborator

@noraconley noraconley commented Jun 28, 2024

Description of the Change

Updates translations to be able to utilize .org GlotPress.

  • Updates text domain from mailchimp_i18n to mailchimp to match plugin slug
  • Removes po files
  • Removes text domain load functionality
  • Updates translators: helper text

Closes #10

How to test the Change

  • No visual regressions
  • Translations will no longer be available internally and will rely on connection to translate.wordpress.org

Changelog Entry

Changed: moves translations to translate.wordpress.org GlotPress

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@noraconley noraconley requested a review from dkotter June 28, 2024 00:18
@noraconley noraconley self-assigned this Jun 28, 2024
@github-actions github-actions bot added this to the 1.6.0 milestone Jun 28, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 28, 2024
@dkotter
Copy link
Collaborator

dkotter commented Jun 28, 2024

@nateconley This looks good to me 👍🏻

I've gone through and found a few strings we weren't translating so added those. Also made some changes mostly for consistency around the use of esc_html__ vs __() or esc_html( __() ). If you could give a quick look at that commit to ensure I didn't mess anything up, that would be great: cae09ce

@noraconley
Copy link
Collaborator Author

noraconley commented Jun 28, 2024

@dkotter Thanks for getting those added in. I ran through the code, the admin page, and front end. Everything looks good.

@dkotter dkotter merged commit 225f432 into develop Jun 28, 2024
@dkotter dkotter deleted the feat/translation-updates branch June 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@noraconley noraconley

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

Update / replace translation files

3 participants

@noraconley @dkotter