Conversation
dkotter
left a comment
dkotter
left a comment
There was a problem hiding this comment.
Code here looks fine to me, though it would be great if there was a better way to detect when to turn off SSR instead of just using a hardcoded list.
I guess also curious if we want to put effort into adjusting any front-end styling? In testing with Twenty Twenty One, styling looked pretty good (I'm assuming because of the custom styling that theme uses). But in testing with Twenty Twenty Four, there's definitely some improvements we could make, like better padding for the form inputs and better button styling:
But I also realize most sites will have custom styling for form inputs, so always a balance of not wanting to impact those styles while still having a good default baseline.
|
@dkotter To address your concerns on Twenty Twenty-Four, here is what Contact Form 7 looks like: I think the best path forward here might be to add field "Padding" and "Button" settings to the "Custom Styling" section - I can add that in. For the denylist, I think this is going to be difficult to accomplish consistently, as we really don't have a reliable way to figure out how much of the theme style is added to the editor. |
|
@nateconley Sorry, just saw your message as I was working on this. I've added in some basic padding to all form elements and things look much better to me now with the ability to still easily override that on a theme level: 
Though feel free to adjust further if needed |
|
@dkotter If this is working well across themes, I think this is a great path forward. Thanks! |
|
@dkotter I gave this a quick look in themes 2024, 2023, 2022, and 2021 and it looks great! |
2 participants
Description of the Change
Disallows legacy themes from server side render in the block editor. These older themes do not have the full stylesheet enabled in the block editor and will instead apply core's
forms.cssfor admin forms.Closes #2
How to test the Change
Changelog Entry
Credits
@nateconley
Checklist: