Skip to content

Make settings page top-level #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkotter merged 1 commit into from
Jun 17, 2024
Merged

Make settings page top-level #29

dkotter merged 1 commit into from
Jun 17, 2024

Conversation

@noraconley
Copy link
Collaborator

@noraconley noraconley commented Jun 17, 2024

Description of the Change

  • Moves settings to top-level menu page
  • Adds "Freddie" icon from files provided to us
    • Followed ElasticPress style of 84.66% width SVG and inline base64 encoded

Closes #8

How to test the Change

  • Settings save as expected
  • Settings styles are maintained

Changelog Entry

Changed - Moves settings page to top-level

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly. - N/A
  • I have added tests to cover my change. - N/A
  • All new and existing tests pass.

@noraconley noraconley requested a review from dkotter June 17, 2024 05:33
@noraconley noraconley self-assigned this Jun 17, 2024
@github-actions github-actions bot added this to the 1.6.0 milestone Jun 17, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 17, 2024
@dkotter dkotter merged commit 11a4124 into develop Jun 17, 2024
@dkotter dkotter deleted the feat/move-menu-page branch June 17, 2024 14:07
This was referenced Jun 17, 2024
Closed
Merged
@dkotter dkotter mentioned this pull request Sep 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@noraconley noraconley

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

Move plugin menu item to top-level in WP admin

3 participants

@noraconley @dkotter