Skip to content

Conversation

@noraconley
Copy link
Collaborator

@noraconley noraconley commented Jun 12, 2024

Description of the Change

Important Note: Known deprecation warnings will be thrown for WordPress 6.1.1 and newer PHP versions:

PHP Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

PHP Deprecated: Calling get_class() without arguments is deprecated

Testing WordPress 6.1.1 with PHP 8.0 will not display these deprecations.

Closes #1

How to test the Change

Environments

  • WordPress core version 6.5.4
  • WordPress core version 6.1.1
  • Theme Twenty Twenty-Four
  • Theme Twenty Twenty-One

Acceptance

  • Shortcode [mailchimpsf_widget] works as expected
  • Widget works as expected

Changelog Entry

Added - compatibility to WordPress 6.5.4
Deprecated - support for WordPress < 6.1.1
Removed - polyfills for WordPress < 2.8.0
Removed - deprecated jQuery scrollTo

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@noraconley noraconley requested a review from dkotter June 12, 2024 01:15
@noraconley noraconley self-assigned this Jun 12, 2024
@github-actions github-actions bot added this to the 1.6.0 milestone Jun 12, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 12, 2024
@noraconley noraconley changed the title Feat/wp 65 compat Feat: WordPress 6.5.4 Compatibility Jun 12, 2024
@dkotter dkotter merged commit 292d89d into develop Jun 12, 2024
@dkotter dkotter deleted the feat/wp-65-compat branch June 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WordPress 6.5 compatibility

3 participants