Skip to content

Conversation

@iamdharmesh
Copy link
Collaborator

Description of the Change

As mentioned in #172, we now support separate lists for each block, multiple forms on a single page should be allowed. This PR make changes to allow multiple forms on a single page.

Closes #172

How to test the Change

  1. Create a page.
  2. Add a Form block, then add another Form block and save the page.
  3. Visit the page on the front end and ensure both forms are functional without any issues.
  4. Switch to a block theme if you're not already using one.
  5. Open the Site Editor and add a Subscribe Form in the footer.
  6. Create a new page, add a form to the page, and save it.
  7. Visit the page and confirm that both the footer form and the page form are working correctly.

Changelog Entry

Changed - Allowed multiple Mailchimp forms on a single page.
Changed - Updated form ID and form field IDs. (If you're using ID selectors for custom styling, please update the selectors accordingly.)

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Jul 18, 2025
@github-actions github-actions bot added this to the Future Release milestone Jul 18, 2025
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 18, 2025
@iamdharmesh iamdharmesh requested a review from dkotter July 18, 2025 17:37
@iamdharmesh iamdharmesh modified the milestones: Future Release, 2.0.0 Jul 18, 2025
dkotter
dkotter previously approved these changes Jul 18, 2025
Copy link
Collaborator

@qasumitbagthariya qasumitbagthariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Update ✅


I have verified this PR in the enhancement/172 branch, which has been fixed and is functioning as intended.

I tested the following on this branch:

  • Verified that multiple forms, two on a page and one in the footer, function correctly on the front end after creation and theme switch.
Screen.Recording.2025-07-23.at.2.34.50.AM.mov
Screen.Recording.2025-07-22.at.7.59.12.PM.mov

Testing Environment

  • WordPress: 6.8.2
  • Theme: Storefront 4.6.1
  • Theme: Twenty Twenty-Four 1.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: enhancement/172

cc @vikrampm1

@qasumitbagthariya
Copy link
Collaborator

Regression / Smoke Test Report ✅

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

  • WordPress: 6.8.2
  • Theme: Twenty Twenty-Five 1.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Aug 7, 2025
@vikrampm1 vikrampm1 mentioned this pull request Aug 7, 2025
30 tasks
@dkotter
Copy link
Collaborator

dkotter commented Aug 7, 2025

@iamdharmesh Can you help fix up the merge conflicts here?

@iamdharmesh iamdharmesh dismissed stale reviews from qasumitbagthariya and dkotter via 1e79368 August 7, 2025 16:37
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Aug 7, 2025
@iamdharmesh
Copy link
Collaborator Author

@dkotter Done.

@dkotter dkotter merged commit e70811b into develop Aug 7, 2025
9 of 12 checks passed
@dkotter dkotter deleted the enhancement/172 branch August 7, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Multiple Mailchimp Form Blocks per Page

4 participants