-
Notifications
You must be signed in to change notification settings - Fork 1
Allow multiple Mailchimp forms on a single page. #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Update ✅
I have verified this PR in the enhancement/172 branch, which has been fixed and is functioning as intended.
I tested the following on this branch:
- Verified that multiple forms, two on a page and one in the footer, function correctly on the front end after creation and theme switch.
Screen.Recording.2025-07-23.at.2.34.50.AM.mov
Screen.Recording.2025-07-22.at.7.59.12.PM.mov
Testing Environment
- WordPress: 6.8.2
- Theme: Storefront 4.6.1
- Theme: Twenty Twenty-Four 1.3
- PHP: 8.0.30
- Web Server: Nginx 1.20.2
- Browser: Chrome
- OS: macOS 15.2
- Branch: enhancement/172
cc @vikrampm1
Regression / Smoke Test Report ✅Status- Working expected with Plugin Archive/Zip file same as fix specific branch. Testing Environment
Next Step- Ready to Merge 🚀 |
|
@iamdharmesh Can you help fix up the merge conflicts here? |
1e79368
|
@dkotter Done. |
Description of the Change
As mentioned in #172, we now support separate lists for each block, multiple forms on a single page should be allowed. This PR make changes to allow multiple forms on a single page.
Closes #172
How to test the Change
Changelog Entry
Credits
Props @iamdharmesh
Checklist: