Skip to content

Add a confirmation prompt before logging out the user. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikrampm1 merged 2 commits into from
May 8, 2025
Merged

Add a confirmation prompt before logging out the user. #149

vikrampm1 merged 2 commits into from
May 8, 2025

Conversation

@iamdharmesh
Copy link
Collaborator

@iamdharmesh iamdharmesh commented Apr 10, 2025

Description of the Change

As reported in #147, currently we do not ask for confirmation before logging out the user. This PR introduces a minor improvement by adding a confirmation prompt before the user is logged out.

Closes #147

How to test the Change

  1. Log in with your Mailchimp account on the plugin settings page.
  2. Click Logout and verify that a confirmation prompt appears before logging out.

Changelog Entry

Added - Confirmation prompt before logging out the user.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Apr 10, 2025
@iamdharmesh iamdharmesh requested a review from dkotter April 10, 2025 06:40
@iamdharmesh iamdharmesh added this to the 1.8.0 milestone Apr 10, 2025
@github-actions github-actions bot added the needs:code-review This requires code review. label Apr 10, 2025
@qasumitbagthariya
Copy link
Collaborator

qasumitbagthariya commented Apr 30, 2025

QA Update ✅

I have verified this PR in the fix/147 branch, which has been fixed and is functioning as intended.

I tested the following on this branch:

  • prompt appears before logging out.
mailchimp.149.mov

Testing Environment

  • WordPress: 6.8
  • Theme: Twenty Twenty-Four 1.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: fix/147

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@qasumitbagthariya
Copy link
Collaborator

qasumitbagthariya commented May 8, 2025

Regression / Smoke Test Report ✅

Tested with the smoke-testing branch, it works as expected, similar to the fix-specific branch.

Testing Environment

  • WordPress: 6.8
  • Theme: Storefront 4.6.0
  • Theme: Twenty Twenty-Four 1.3
  • WooCommerce - 9.8.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 merged commit 423be9d into develop May 8, 2025
12 checks passed
@vikrampm1 vikrampm1 mentioned this pull request May 8, 2025
Closed
22 tasks
@dkotter dkotter deleted the fix/147 branch May 8, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

@qasumitbagthariya qasumitbagthariya qasumitbagthariya approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Add a confirmation prompt before logging out from the account

5 participants

@iamdharmesh @qasumitbagthariya @dkotter @vikrampm1