Skip to content

Conversation

@iamdharmesh
Copy link
Collaborator

@iamdharmesh iamdharmesh commented Mar 25, 2025

Description of the Change

This PR is a follow-up to PR #126, as discussed here.

It removes group visibility settings from the block sidebar and adds groups as an inner block to allow reordering.

Additionally, the PR changes the default value of some attributes from static values to values from the global settings.

Screenshot 2025-03-25 at 7 49 06 PM

How to test the Change

  1. Insert the "Mailchimp List Subscribe Form" block in the editor and verify that the group's visibility is pre-selected based on the current settings.
  2. Reorder the groups, save the block, and check that the front end displays the groups in the configured order.
  3. Update the groups' visibility and ensure the changes are accurately reflected on the front end.
  4. Add or remove groups in the Mailchimp settings, then go to wp-admin Mailchimp settings, click "Update List" to fetch the latest groups, edit the block, and verify that the groups update accordingly.

Changelog Entry

N/A

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Mar 25, 2025
@iamdharmesh iamdharmesh marked this pull request as ready for review March 25, 2025 16:44
@iamdharmesh iamdharmesh requested a review from dkotter March 25, 2025 16:44
@iamdharmesh iamdharmesh added this to the 1.7.0 milestone Mar 25, 2025
@qasumitbagthariya
Copy link
Collaborator

QA Update ✅


I have verified this PR in the enhancement/82-2 branch, which has been fixed and is functioning as intended.

I tested the following on this branch:

  • Group visibility
  • Reorder the groups
  • Add or remove groups
Screen.Recording.2025-03-26.at.5.57.16.PM.mov

Testing Environment

  • WordPress: 6.7.2
  • Theme: Storefront 4.6.1
  • Theme: Twenty Twenty-Four 1.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: enhancement/82-2

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@dkotter dkotter merged commit 75ad39b into enhancement/82 Mar 31, 2025
@dkotter dkotter deleted the enhancement/82-2 branch March 31, 2025 14:36
@vikrampm1 vikrampm1 mentioned this pull request Apr 7, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants