-
Notifications
You must be signed in to change notification settings - Fork 1
Mailchimp Block Updates #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… innerblocks in mailchimp form block.
…Styling" if it is not enabled.
dkotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
includes/blocks/mailchimp/edit.js
Outdated
| </div> | ||
| )} | ||
| <Disabled> | ||
| <InterestGroups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like any groups that are shown can't be moved, is that correct? Would be nice to be able to move those around like other fields if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, groups are not added as inner blocks, so they are not movable. I placed them in the sidebar to differentiate them from form fields, and I’m not sure how frequently users use them.
However, we can make them movable by converting them into inner blocks. Once converted, they will function like form fields, and their visibility can be managed directly from the editor.
I think it would be good to make them work like form fields. Should I convert them into inner blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think user expectation is that they'll be able to move these around like other fields so if we can accomplish that, I think that's the way to go. That said, I don't think it's critical and we could tackle that in a follow-up PR if we want, that way we can continue to move this along
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will raise the follow-up PR next week. Thanks
Co-authored-by: Darin Kotter <[email protected]>
QA Update ✅I have verified this PR in the I tested the following on this branch:
Screen.Recording.2025-03-25.at.6.44.50.PM.movScreen.Recording.2025-03-25.at.6.59.20.PM.movTesting Environment
Steps to Test- As mentioned in the PR description.
|
[Block Updates] Move Audience Groups to the InnerBlocks to allow reordering.
Regression / Smoke Test Report ✅Tested with the Testing Environment
Next Step- Ready to Merge 🚀 |

Description of the Change
The PR updates the Mailchimp form block to include settings for selecting an audience list, reordering fields, toggling field and group visibility, adjusting padding and margin, typography settings, and modifying colors. The following major changes were made as part of these block updates:
Block Updates:
Settings Page Updates:
Screen.Recording.2025-03-19.at.12.56.07.PM.mov
Note
Closes #82
How to test the Change
Backward Compatibility:
Changelog Entry
Credits
Props @jeffpaul @dkotter @iamdharmesh
Checklist: