Repository navigation
Conversation
Signed-off-by: Ali Zulfiqar <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the verified division-by-zero path and the added tests cover the reported regressions without introducing API or behavioral inconsistencies beyond the intended fallback.
Pull request overview
This pull request fixes a division-by-zero failure in Stats automatic histogram bin selection when the interquartile range is zero (e.g., constant data, or many repeated values with an outlier). It does so by detecting a zero Freedman–Diaconis bin width and falling back to a single-bin histogram, and adds regression tests to cover the affected scenarios.
Changes:
- Add a
dx == 0guard in Freedman-based bin bound calculation to avoid dividing by zero and to produce a one-bin result. - Add tests covering constant datasets and a repeated-value dataset with an outlier to ensure both
get_histogram_counts()andformat_histogram()behave without error.
File summaries
| File | Description |
|---|---|
boltons/statsutils.py |
Adds a zero-width Freedman fallback to produce a single histogram bin instead of dividing by zero. |
tests/test_statsutils.py |
Adds regression coverage for zero-IQR datasets (constant values and repeated values with an outlier). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic histogram bins divide by zero when the interquartile range is zero, including constant datasets. Fall back to one bin spanning the data when the Freedman width is zero.
Adds regressions for constant values and a repeated value with an outlier.