Skip to content

fix(mme): Replace RETURNerror with RETURNok in timer handlers#9416

Merged
ardzoht merged 1 commit intomagma:masterfrom
ulaskozat:fix_timer_exp_handler_returns
Oct 4, 2021
Merged

fix(mme): Replace RETURNerror with RETURNok in timer handlers#9416
ardzoht merged 1 commit intomagma:masterfrom
ulaskozat:fix_timer_exp_handler_returns

Conversation

@ulaskozat
Copy link
Copy Markdown
Contributor

Signed-off-by: Ulas Kozat [email protected]

Summary

There were few handlers that were not fixed in #8648. If these RETURNerror's are hit during run time, it leads to premature thread exits leading the repeated mme restarts and eventual sctpd restarts.

Test Plan

Additional Information

  • This change is backwards-breaking

@ulaskozat ulaskozat requested a review from a team October 3, 2021 19:42
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 3, 2021
@ulaskozat ulaskozat requested a review from ardzoht October 3, 2021 19:42
@github-actions github-actions bot added component: agw Access gateway-related issue and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 3, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2021

cloud-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit d2a50eb.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2021

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit d2a50eb.

@ulaskozat ulaskozat added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 labels Oct 3, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2021

feg-workflow

    2 files  145 suites   29s ⏱️
338 tests 338 ✔️ 0 💤 0
352 runs  352 ✔️ 0 💤 0

Results for commit d2a50eb.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2021

agw-workflow

    2 files      2 suites   3m 52s ⏱️
473 tests 464 ✔️ 9 💤 0
474 runs  465 ✔️ 9 💤 0

Results for commit d2a50eb.

Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ardzoht ardzoht linked an issue Oct 4, 2021 that may be closed by this pull request
@ardzoht ardzoht merged commit bfe33ef into magma:master Oct 4, 2021
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 component: agw Access gateway-related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGW: frequent mme service restarts [agw] MME tasks zloop's event loops exit due to timer handling and UE context don't exist

2 participants