Skip to content

fix(mme): Fix NAS common procedure check segfaults#8808

Merged
ardzoht merged 2 commits intomagma:masterfrom
ardzoht:fix_get_nas_common_procedure_segv
Aug 26, 2021
Merged

fix(mme): Fix NAS common procedure check segfaults#8808
ardzoht merged 2 commits intomagma:masterfrom
ardzoht:fix_get_nas_common_procedure_segv

Conversation

@ardzoht
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht commented Aug 26, 2021 •
edited
Loading

Summary

  • Sentry error monitoring has reported crashes due to SegFault on common procedure checks part of nas_procedures functions
  • Errors are mostly observed during running deployment on Spirent AGWs

Test Plan

  • Running make integ_test for sanity

Additional Information

@ardzoht ardzoht requested review from a team August 26, 2021 21:18
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 26, 2021
@ardzoht ardzoht requested review from pshelar and ulaskozat August 26, 2021 21:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 26, 2021
@ardzoht ardzoht force-pushed the fix_get_nas_common_procedure_segv branch from dd5c711 to 40e11c7 Compare August 26, 2021 21:19
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 26, 2021
@ardzoht ardzoht force-pushed the fix_get_nas_common_procedure_segv branch from 40e11c7 to c54052c Compare August 26, 2021 21:21
ulaskozat
ulaskozat approved these changes Aug 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulaskozat ulaskozat linked an issue Aug 26, 2021 that may be closed by this pull request
get_nas_common_procedure #8797
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2021

feg-workflow

    2 files  145 suites   30s ⏱️
338 tests 338 ✔️ 0 💤 0 ❌
352 runs  352 ✔️ 0 💤 0 ❌

Results for commit c54052c.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2021

agw-workflow

    2 files      2 suites   2m 58s ⏱️
464 tests 455 ✔️ 9 💤 0 ❌
465 runs  456 ✔️ 9 💤 0 ❌

Results for commit c54052c.

@ardzoht ardzoht merged commit 3530335 into magma:master Aug 26, 2021
ardzoht added a commit to ardzoht/magma that referenced this pull request Aug 27, 2021
@ardzoht
fix(mme): Fix NAS common procedure check segfaults (magma#8808)
82d8c7b 
* fix(agw): Fixing too many open files OS error by monitord async icmp

Signed-off-by: Alex Rodriguez <[email protected]>

* fix(mme): Fix SIGSEGV faults on proc checks on nas_procedures.c

Signed-off-by: Alex Rodriguez <[email protected]>
@ardzoht ardzoht mentioned this pull request Aug 27, 2021
Merged
1 task
@markjen
Copy link
Copy Markdown
Contributor

markjen commented Aug 27, 2021

marking this commit backported-v1.5 since #8811 backports manually

markjen pushed a commit that referenced this pull request Aug 27, 2021
@ardzoht
fix(mme): Fix NAS common procedure check segfaults (#8808)
b0922d3 
* fix(agw): Fixing too many open files OS error by monitord async icmp

Signed-off-by: Alex Rodriguez <[email protected]>

* fix(mme): Fix SIGSEGV faults on proc checks on nas_procedures.c

Signed-off-by: Alex Rodriguez <[email protected]>
markjen pushed a commit that referenced this pull request Aug 27, 2021
@ardzoht
fix(mme): Fix NAS common procedure check segfaults (#8808)
c3c21d4 
* fix(agw): Fixing too many open files OS error by monitord async icmp

Signed-off-by: Alex Rodriguez <[email protected]>

* fix(mme): Fix SIGSEGV faults on proc checks on nas_procedures.c

Signed-off-by: Alex Rodriguez <[email protected]>
ulaskozat pushed a commit that referenced this pull request Aug 27, 2021
@ardzoht
fix(mme): Fix NAS common procedure check segfaults (#8808) (#8811)
935a89a 
* fix(agw): Fixing too many open files OS error by monitord async icmp

Signed-off-by: Alex Rodriguez <[email protected]>
@ardzoht ardzoht removed apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 apply-v1.7 labels Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulaskozat ulaskozat ulaskozat approved these changes

@pshelar pshelar Awaiting requested review from pshelar

Assignees

No one assigned

Labels

backported-v1.5 backported-v1.6 backported-v1.7 component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_nas_common_procedure

3 participants

@ardzoht @markjen @ulaskozat