feat(session_proxy): add a flag to disable Service Requested Unit AVP#8697
Merged
uri200 merged 1 commit intomagma:masterfrom Aug 20, 2021
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯 A couple initial guidelines
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
uri200
added
apply-v1.6
apply-v1.7
apply-v1.5
Contributor
feg-workflow 2 files 145 suites 30s ⏱️ Results for commit 18fe0a6. ♻️ This comment has been updated with latest results. |
emakeev
requested changes
Aug 19, 2021
| configsPtr := &mconfig.SessionProxyConfig{} | ||
| err := managed_configs.GetServiceConfigs(credit_control.SessionProxyServiceName, configsPtr) | ||
| siStr := diameter.GetValueOrEnv(OCSServiceIdentifierFlag, OCSServiceIdentifierEnv, "") | ||
| avp437 := diameter.GetValueOrEnv(OCSServiceIdentifierFlag, DisableRequestedGrantedUnitsAVPEnv, "") |
Contributor
There was a problem hiding this comment.
copy/paste, should be:
avp437 := diameter.GetValueOrEnv(DisableRequestedGrantedUnitsAVPFlag, DisableRequestedGrantedUnitsAVPEnv, "")
emakeev
requested changes
Aug 19, 2021
Contributor
emakeev
left a comment
emakeev
left a comment
There was a problem hiding this comment.
please see comment inline.
emakeev
reviewed
Aug 19, 2021
Contributor
emakeev
left a comment
emakeev
left a comment
There was a problem hiding this comment.
pls, see comments inline
| OCSServiceIdentifier string | ||
| DisableGy bool | ||
| VirtualApnRules []*credit_control.VirtualApnRule | ||
| DisableServiceGrantedUnitsAVP string |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to make it bool? Like DisableGy above
| _ = flag.String(GyInitMethodFlag, "", "Gy init method (per_key|per_session)") | ||
| _ = flag.String(OCSApnOverwriteFlag, "", "OCS APN to use instead of request's APN") | ||
| _ = flag.String(OCSServiceIdentifierFlag, "", "OCS ServiceIdentifier to use in Gy requests") | ||
| _ = flag.String(DisableRequestedGrantedUnitsAVPFlag, "", "Disable Requested-Service-Unit AVP (437)") |
Contributor
There was a problem hiding this comment.
I'd make it Bool here.
avp437Flag = flag.Bool(DisableRequestedGrantedUnitsAVPFlag, false, "Disable Requested-Service-Unit AVP (437)")
| configsPtr := &mconfig.SessionProxyConfig{} | ||
| err := managed_configs.GetServiceConfigs(credit_control.SessionProxyServiceName, configsPtr) | ||
| siStr := diameter.GetValueOrEnv(OCSServiceIdentifierFlag, OCSServiceIdentifierEnv, "") | ||
| avp437 := diameter.GetValueOrEnv(OCSServiceIdentifierFlag, DisableRequestedGrantedUnitsAVPEnv, "") |
Contributor
There was a problem hiding this comment.
I think, it may be cleaner to make it bool, you can do something like this:
avp437 := *avp437Flag || util.IsTruthyEnv(DisableRequestedGrantedUnitsAVPEnv)
56113b2 to
ce45c4a
Compare
Signed-off-by: Oriol Batalla <[email protected]>
uri200
force-pushed
the
session_proxy_disable_granted_units_AVP
branch
from
ce45c4a to
18fe0a6
Compare
hakeen0618
pushed a commit
to hakeen0618/magma
that referenced
this pull request
Aug 24, 2021
markjen
pushed a commit
that referenced
this pull request
Aug 26, 2021
uri200
removed
the
apply-v1.5
This was referenced Aug 26, 2021
Closed
markjen
pushed a commit
that referenced
this pull request
Aug 26, 2021
markjen
pushed a commit
that referenced
this pull request
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oriol Batalla [email protected]
Summary
To support some specific vendors we need to set Service Requested Unit AVP as empty. This PR adds a flag to session_proxy service to disable that AVP.
To disable that, go to
.envfile and crateTest Plan
Additional Information