Skip to content

fix(sessiond): increase default_requested_units to 10Mb #8671

Merged
uri200 merged 1 commit intomagma:masterfrom
uri200:sessiond_increase_default_requested_units
Aug 18, 2021
Merged

fix(sessiond): increase default_requested_units to 10Mb #8671
uri200 merged 1 commit intomagma:masterfrom
uri200:sessiond_increase_default_requested_units

Conversation

@uri200
Copy link
Copy Markdown
Contributor

@uri200 uri200 commented Aug 18, 2021 •
edited
Loading

Signed-off-by: Oriol Batalla [email protected]

Summary

Increased value of default_requested_units on sessiond from 200kb to 10mb.

Having such a low value by default causes sessiond to spam FEG with bunch of update request when we have subscribers using data at a normal pace

Note we only change the default values. Values for cwag_integ_test are kept to 200kb in order to trigger those Update Request more often and reduce the execution time of the test.

Test Plan

Test project /home/vagrant/build/c/session_manager
      Start  1: test_polling_pipelined
 1/17 Test  #1: test_polling_pipelined ...............   Passed    0.03 sec
      Start  2: test_session_credit
 2/17 Test  #2: test_session_credit ..................   Passed    1.02 sec
      Start  3: test_local_enforcer
 3/17 Test  #3: test_local_enforcer ..................   Passed    1.83 sec
      Start  4: test_cloud_reporter
 4/17 Test  #4: test_cloud_reporter ..................   Passed    0.06 sec
      Start  5: test_session_manager_handler
 5/17 Test  #5: test_session_manager_handler .........   Passed    0.05 sec
      Start  6: test_sessiond_integ
 6/17 Test  #6: test_sessiond_integ ..................   Passed    0.90 sec
      Start  7: test_session_state
 7/17 Test  #7: test_session_state ...................   Passed    0.02 sec
      Start  8: test_session_store
 8/17 Test  #8: test_session_store ...................   Passed    0.03 sec
      Start  9: test_store_client
 9/17 Test  #9: test_store_client ....................   Passed    0.02 sec
      Start 10: test_stored_state
10/17 Test #10: test_stored_state ....................   Passed    0.02 sec
      Start 11: test_proxy_responder_handler
11/17 Test #11: test_proxy_responder_handler .........   Passed    0.04 sec
      Start 12: test_metering_reporter
12/17 Test #12: test_metering_reporter ...............   Passed    0.02 sec
      Start 13: test_local_enforcer_wallet_exhaust
13/17 Test #13: test_local_enforcer_wallet_exhaust ...   Passed    0.04 sec
      Start 14: test_charging_grant
14/17 Test #14: test_charging_grant ..................   Passed    0.01 sec
      Start 15: test_usage_monitor
15/17 Test #15: test_usage_monitor ...................   Passed    0.02 sec
      Start 16: test_upf_node_state
16/17 Test #16: test_upf_node_state ..................   Passed    0.04 sec
      Start 17: test_set_session_manager_handler
17/17 Test #17: test_set_session_manager_handler .....   Passed    0.04 sec

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested a review from a team as a code owner August 18, 2021 15:05
@uri200 uri200 requested review from a team and koolzz August 18, 2021 15:05
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 18, 2021
@uri200 uri200 requested a review from themarwhal August 18, 2021 15:05
@uri200 uri200 linked an issue Aug 18, 2021 that may be closed by this pull request
fix(sessiond): default granted unit value too low #8670
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@uri200 uri200 added apply-v1.3 Needs to be applied to v1.3 release branch as well apply-v1.4 Needs to be applied to v1.4 release branch as well apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 apply-v1.7 labels Aug 18, 2021
@magmabot magmabot added component: agw Access gateway-related issue component: cwag CWAG related issues labels Aug 18, 2021
@uri200 uri200 force-pushed the sessiond_increase_default_requested_units branch from 3f0e28f to c60e51e Compare August 18, 2021 15:07
@uri200 uri200 requested a review from a team August 18, 2021 15:07
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 18, 2021
@uri200 uri200 force-pushed the sessiond_increase_default_requested_units branch from c60e51e to e8ae259 Compare August 18, 2021 15:09
@uri200 uri200 changed the title fix(sessiond): increase to 10Mb default_requested_units fix(sessiond): increase default_requested_units to 10Mb Aug 18, 2021
@uri200 uri200 enabled auto-merge (squash) August 18, 2021 15:12
ulaskozat
ulaskozat approved these changes Aug 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021 •
edited
Loading

feg-workflow

    2 files  145 suites   29s ⏱️
338 tests 338 ✔️ 0 💤 0 ❌
352 runs  352 ✔️ 0 💤 0 ❌

Results for commit 0e44cbf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021 •
edited
Loading

agw-workflow

    2 files      2 suites   3m 7s ⏱️
464 tests 455 ✔️ 9 💤 0 ❌
465 runs  456 ✔️ 9 💤 0 ❌

Results for commit 0e44cbf.

♻️ This comment has been updated with latest results.

@uri200 uri200 force-pushed the sessiond_increase_default_requested_units branch from e8ae259 to 0e44cbf Compare August 18, 2021 15:45
@uri200 uri200 merged commit 5438791 into magma:master Aug 18, 2021
hakeen0618 pushed a commit to hakeen0618/magma that referenced this pull request Aug 24, 2021
@uri200 @hakeen0618
fix(sessiond): increase default_requested_units to 10Mb (magma#8671)
5dddb07
markjen pushed a commit that referenced this pull request Aug 26, 2021
@uri200
fix(sessiond): increase default_requested_units to 10Mb (#8671)
45b062a
@markjen markjen added the backported-v1.3 Has been backported to v1.3 release branch label Aug 26, 2021
markjen pushed a commit that referenced this pull request Aug 26, 2021
@uri200
fix(sessiond): increase default_requested_units to 10Mb (#8671)
853ac77
@markjen markjen added the backported-v1.4 Has been backported to v1.4 release branch label Aug 26, 2021
markjen pushed a commit that referenced this pull request Aug 26, 2021
@uri200
fix(sessiond): increase default_requested_units to 10Mb (#8671)
23d11a9
markjen pushed a commit that referenced this pull request Aug 26, 2021
@uri200
fix(sessiond): increase default_requested_units to 10Mb (#8671)
f52a3fa
markjen pushed a commit that referenced this pull request Aug 26, 2021
@uri200
fix(sessiond): increase default_requested_units to 10Mb (#8671)
49bb4b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulaskozat ulaskozat ulaskozat approved these changes

@themarwhal themarwhal themarwhal approved these changes

@koolzz koolzz Awaiting requested review from koolzz

Assignees

No one assigned

Labels

apply-v1.3 Needs to be applied to v1.3 release branch as well apply-v1.4 Needs to be applied to v1.4 release branch as well apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 apply-v1.7 backported-v1.3 Has been backported to v1.3 release branch backported-v1.4 Has been backported to v1.4 release branch backported-v1.5 backported-v1.6 backported-v1.7 component: agw Access gateway-related issue component: cwag CWAG related issues size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(sessiond): default granted unit value too low

5 participants

@uri200 @ulaskozat @themarwhal @markjen @magmabot