Skip to content

fix(mme): Mitigate timer expiration handler with invalid UE context causes MME app thread exit#8648

Merged
ardzoht merged 1 commit intomagma:masterfrom
ardzoht:mitigate_mme_expiration_handler_exits
Aug 17, 2021
Merged

fix(mme): Mitigate timer expiration handler with invalid UE context causes MME app thread exit#8648
ardzoht merged 1 commit intomagma:masterfrom
ardzoht:mitigate_mme_expiration_handler_exits

Conversation

@ardzoht
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht commented Aug 16, 2021

Signed-off-by: Alex Rodriguez [email protected]

Summary

  • This is a mitigation change intended to avoid MME app thread exiting due to the initial context setup response timer expiration handler returning -1 response code due to UE context already being freed due to race condition.
  • Updates all timer expiration handlers to return RETURNOk response code

Test Plan

  • Tested on integ tests as sanity and spirent testing with active_idle_sequencer_mode.py
  • Tested on live deployment which was facing issues and service restarts, it has been reported no restart since patch was applied

Additional Information

  • This change is backwards-breaking

@ardzoht
fix(mme): Mitigate timer expiration handler with invalid UE context c…
73d43ff 
…auses MME app thread exit

Signed-off-by: Alex Rodriguez <[email protected]>
@ardzoht ardzoht requested review from a team and ulaskozat August 16, 2021 17:43
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 16, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@ardzoht ardzoht mentioned this pull request Aug 16, 2021
Closed
1 task
@ardzoht ardzoht added the component: agw Access gateway-related issue label Aug 16, 2021
@ardzoht ardzoht linked an issue Aug 16, 2021 that may be closed by this pull request
[agw] MME tasks zloop's event loops exit due to timer handling and UE context don't exist #8604
Closed
ulaskozat
ulaskozat approved these changes Aug 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2021

feg-workflow

    2 files  145 suites   29s ⏱️
338 tests 338 ✔️ 0 💤 0 ❌
352 runs  352 ✔️ 0 💤 0 ❌

Results for commit 73d43ff.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2021

agw-workflow

    2 files      2 suites   2m 40s ⏱️
464 tests 455 ✔️ 9 💤 0 ❌
465 runs  456 ✔️ 9 💤 0 ❌

Results for commit 73d43ff.

@ardzoht ardzoht merged commit d0b4cdc into magma:master Aug 17, 2021
@ardzoht ardzoht added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 apply-v1.7 labels Aug 17, 2021
tmdzk pushed a commit that referenced this pull request Aug 17, 2021
@ardzoht @tmdzk
fix(mme): Mitigate timer expiration handler with invalid UE context c…
4f9dbce 
…auses MME app thread exit (#8648)

Signed-off-by: Alex Rodriguez <[email protected]>
tmdzk pushed a commit that referenced this pull request Aug 17, 2021
@ardzoht @tmdzk
fix(mme): Mitigate timer expiration handler with invalid UE context c…
9064cb7 
…auses MME app thread exit (#8648)

Signed-off-by: Alex Rodriguez <[email protected]>
tmdzk pushed a commit that referenced this pull request Aug 17, 2021
@ardzoht @tmdzk
fix(mme): Mitigate timer expiration handler with invalid UE context c…
912c4d7 
…auses MME app thread exit (#8648)

Signed-off-by: Alex Rodriguez <[email protected]>
hakeen0618 pushed a commit to hakeen0618/magma that referenced this pull request Aug 24, 2021
@ardzoht @hakeen0618
fix(mme): Mitigate timer expiration handler with invalid UE context c…
0aaf3ae 
…auses MME app thread exit (magma#8648)

Signed-off-by: Alex Rodriguez <[email protected]>
@ardzoht ardzoht mentioned this pull request Aug 25, 2021
Closed
@ulaskozat ulaskozat mentioned this pull request Oct 3, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulaskozat ulaskozat ulaskozat approved these changes

Assignees

No one assigned

Labels

apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 apply-v1.7 backported-v1.5 backported-v1.6 backported-v1.7 component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[agw] MME tasks zloop's event loops exit due to timer handling and UE context don't exist

2 participants

@ardzoht @ulaskozat