fix(mme): assert on single thread exits#8455
Merged
ulaskozat merged 2 commits intomagma:masterfrom Aug 4, 2021
Merged
Conversation
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
|
Thanks for opening a PR! 💯 A couple initial guidelines
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
feg-workflow 2 files 145 suites 30s ⏱️ Results for commit ff84bef. ♻️ This comment has been updated with latest results. |
ulaskozat
added
apply-v1.5
ulaskozat
added a commit
to ulaskozat/magma
that referenced
this pull request
Aug 4, 2021
* fix(mme): assert on single thread exits Signed-off-by: Ulas Kozat <[email protected]>
ulaskozat
added a commit
that referenced
this pull request
Aug 4, 2021
* fix(mme): assert on single thread exits Signed-off-by: Ulas Kozat <[email protected]>
ulaskozat
added a commit
to ulaskozat/magma
that referenced
this pull request
Aug 4, 2021
* fix(mme): assert on single thread exits Signed-off-by: Ulas Kozat <[email protected]>
1 task
ulaskozat
added a commit
that referenced
this pull request
Aug 4, 2021
* fix(mme): assert on single thread exits Signed-off-by: Ulas Kozat <[email protected]>
themarwhal
removed
the
apply-v1.5
Member
|
Removing the apply-v1.5 label for now as there are too many merge conflicts. @ulaskozat do you mind raising a separate PR for this? |
Contributor
Author
|
@themarwhal I already backported this yesterday, maybe that is the reason for the merge conflicts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ulas Kozat [email protected]
Summary
MME service is vulnerable to the cases where a single thread exits leaving the rest of the threads keep running. This PR asserts on such events forcing the process to exit.
Test Plan
S1AP integ tests.
Additional Information