Skip to content

fix(agw): enable GTP echo#8328

Merged
pshelar merged 1 commit intomagma:masterfrom
pshelar:turn-on-echo1
Aug 5, 2021
Merged

fix(agw): enable GTP echo#8328
pshelar merged 1 commit intomagma:masterfrom
pshelar:turn-on-echo1

Conversation

@pshelar
Copy link
Copy Markdown
Contributor

@pshelar pshelar commented Jul 29, 2021 •
edited
Loading

The GTP echo functionality regression is fixed. Following
commit enables the GTP echo on the AGW.

Signed-off-by: Pravin B Shelar [email protected]

Summary

Test Plan

validate on vagrant and TVM: both test passed.

ng40@facebook-1-vhopran:~/magma/automation$ ng40test inbound_roaming_08.ntl
Open NG40 logger: Name = inbound_roaming_08_210804_171919-1; ID = 1

**** 1. Starting regression test system **************

Connect to shell facebook in path /home/ng40/magma on 192.168.60.75 as ng40
Load call scenario facebook /home/ng40/magma/testplan_roaming.conf
++++ Precondition: testplan testcases loaded
++++ Precondition: facebook up & running
++++ Precondition: status of LTE ENBs
cmd enb_mme_state 0 0: ENB(0) MME(0) Status: active

**** 2. Executing regression test cases **************

**** TOTAL number of test cases:1

cmd setmessagedelay gyocs 2500:
cmd setmessagedelay gxpcrf 2500:

Run test case (1) on facebook: inbound_roaming_08()
Verdict(inbound_roaming_08) = VERDICT_PASS

**** 3. Finished regression test cases **************

Testlist verdict = VERDICT_PASS
Closing NG40 logger: Name = inbound_roaming_08_210804_171919-1; ID = 1
 >>>>>>>> close <<<<<<<<<
ng40@facebook-1-vhopran:~/magma/automation$ ng40test inbound_roaming_08b.ntl
Open NG40 logger: Name = inbound_roaming_08b_210804_172015-1; ID = 1

**** 1. Starting regression test system **************

Connect to shell facebook in path /home/ng40/magma on 192.168.60.75 as ng40
Load call scenario facebook /home/ng40/magma/testplan_roaming.conf
++++ Precondition: testplan testcases loaded
++++ Precondition: facebook up & running
++++ Precondition: status of LTE ENBs
cmd enb_mme_state 0 0: ENB(0) MME(0) Status: active

**** 2. Executing regression test cases **************

**** TOTAL number of test cases:1

cmd setmessagedelay gyocs 2500:
cmd setmessagedelay gxpcrf 2500:

Run test case (1) on facebook: inbound_roaming_08b()
Verdict(inbound_roaming_08b) = VERDICT_PASS

**** 3. Finished regression test cases **************

Testlist verdict = VERDICT_PASS
Closing NG40 logger: Name = inbound_roaming_08b_210804_172015-1; ID = 1
 >>>>>>>> close <<<<<<<<<

Additional Information

  • This change is backwards-breaking

@pshelar
fix(agw): enable GTP echo
7544230 
The GTP echo functionality regression is fixed. Following
commit enables the GTP echo on the AGW.

Signed-off-by: Pravin B Shelar <[email protected]>
@pshelar pshelar requested a review from a team as a code owner July 29, 2021 05:50
@pshelar pshelar requested a review from a team July 29, 2021 05:50
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jul 29, 2021
@pshelar pshelar requested a review from ulaskozat July 29, 2021 05:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2021

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@magmabot magmabot added the component: agw Access gateway-related issue label Jul 29, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2021

feg-workflow

    2 files  145 suites   29s ⏱️
338 tests 338 ✔️ 0 💤 0 ❌
352 runs  352 ✔️ 0 💤 0 ❌

Results for commit 7544230.

@uri200
Copy link
Copy Markdown
Contributor

uri200 commented Aug 2, 2021 •
edited
Loading

Hey @pshelar, we have 2 test in teravm to test echo in case you wanted to run them to test
inbound_roaming_08 and inbound_roaming_08b

@pshelar pshelar mentioned this pull request Aug 3, 2021
Closed
ulaskozat
ulaskozat approved these changes Aug 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pshelar pshelar merged commit fcddec3 into magma:master Aug 5, 2021
pshelar pushed a commit to pshelar/magma that referenced this pull request Aug 16, 2021
fix(agw): enable GTP echo (magma#8328)
31e8df1 
The GTP echo functionality regression is fixed. Following
commit enables the GTP echo on the AGW.

Signed-off-by: Pravin B Shelar <[email protected]>
pshelar added a commit that referenced this pull request Aug 16, 2021
@pshelar
fix(agw): enable GTP echo (#8328) (#8649)
b7ab42d 
The GTP echo functionality regression is fixed. Following
commit enables the GTP echo on the AGW.

Signed-off-by: Pravin B Shelar <[email protected]>

Co-authored-by: Pravin B Shelar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulaskozat ulaskozat ulaskozat approved these changes

Assignees

No one assigned

Labels

backported-v1.5 component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pshelar @uri200 @ulaskozat @magmabot