fix(agw): on AGW reboot bring up SGi interface.#8169
Merged
pshelar merged 1 commit intomagma:masterfrom Jul 20, 2021
Merged
Conversation
In case of missing interface file for SGi interface, the interface does not come up automatically. That can impact SGi connectivity. Following patch handles the case. Signed-off-by: Pravin B Shelar <[email protected]>
Contributor
|
Thanks for opening a PR! 💯 A couple initial guidelines
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Contributor
feg-workflow 2 files 145 suites 30s ⏱️ Results for commit 817c816. |
amarpad
approved these changes
Jul 20, 2021
| sgi_interface = service_config['nat_iface'] | ||
| if_up_cmd = "ip link set dev %s up" % sgi_interface | ||
| subprocess.call(if_up_cmd.split()) | ||
| print("ip up cmd %s", if_up_cmd) |
Contributor
There was a problem hiding this comment.
Lets track a TODO to implement something more Ubuntu native. Thanks for the fix, also would you mind cherry picking this to 1.6/5
Contributor
Author
There was a problem hiding this comment.
actually this is to handle the upgrade case for debian based AGWs.
The ubuntu based AGW installation always makes sure we have interface file for eth0:
pshelar
added
apply-v1.5
themarwhal
pushed a commit
that referenced
this pull request
Jul 21, 2021
In case of missing interface file for SGi interface, the interface does not come up automatically. That can impact SGi connectivity. Following patch handles the case. Signed-off-by: Pravin B Shelar <[email protected]>
themarwhal
pushed a commit
that referenced
this pull request
Jul 21, 2021
In case of missing interface file for SGi interface, the interface does not come up automatically. That can impact SGi connectivity. Following patch handles the case. Signed-off-by: Pravin B Shelar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of missing interface file for SGi interface, the
interface does not come up automatically. That can impact
SGi connectivity.
Following patch handles the case.
Signed-off-by: Pravin B Shelar [email protected]
Summary
Test Plan
validated on AGW:
Additional Information