fix(mme): add config flag to control GTP-U echo#7980
Conversation
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
ardzoht
left a comment
ardzoht
left a comment
There was a problem hiding this comment.
There is a missing config value on yml file I think. Also for these type of changes I'd suggest including on your test plan an output that validates how this value gets updated (on mme.log for example)
| UPLINK_PORT_NUM = {{ ovs_uplink_port_number }}; | ||
| UPLINK_MAC = "{{ ovs_uplink_mac }}"; | ||
| MULTI_TUNNEL = "{{ ovs_multi_tunnel }}"; | ||
| GTP_ECHO = "{{ ovs_gtpu_echo_resp }}"; |
There was a problem hiding this comment.
where is this generated from? there should be a ovs_gtpu_echo_resp config param on spgw.yml that this value updates from.
There was a problem hiding this comment.
in case of missing value, the feature is off. thats why I did not add the variable to yml file.
There was a problem hiding this comment.
Ok got your point, MME config is checking on the existence of the value.
I'd strongly advise against this, at least on MME and OAI configuration generation there is an explicit declaration for all configuration both on mme.yml and spgw.yml files which generate_oai_config parses the values and puts them on the given template.
My preference would be to declare the value on the yml file and use that to control the enablement/disablement of the feature, this way we also have expectations between what different versions of what service configs files should contain.
There was a problem hiding this comment.
cool, and thanks for the validation!
I ran test-attach-detach with this change. and it works. do you see any potential issue due to missing config in this case? |
I just want to confirm validation that |
This is turned off by default to investigate perf regression. Signed-off-by: Pravin B Shelar <[email protected]>
MME restart and performs as per the config for the attach-detach-test. it does validate generate_oai_config, right? |
This is turned off by default to investigate perf regression. Signed-off-by: Pravin B Shelar <[email protected]>
This is turned off by default to investigate perf regression. Signed-off-by: Pravin B Shelar <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
This is turned off by default to investigate perf regression. Signed-off-by: Pravin B Shelar <[email protected]>
4 participants
This is turned off by default to fix perf regression.
Signed-off-by: Pravin B Shelar [email protected]
Summary
Test Plan
validated it on vagrant test setup.
Additional Information