Skip to content

fix(mme): Fix for mme crash observed in test_3495_timer_for_defa…#7941

Merged
amarpad merged 1 commit intomagma:v1.5from
amarpad:pick_2
Jul 12, 2021
Merged

fix(mme): Fix for mme crash observed in test_3495_timer_for_defa…#7941
amarpad merged 1 commit intomagma:v1.5from
amarpad:pick_2

Conversation

@amarpad
Copy link
Copy Markdown
Contributor

@amarpad amarpad commented Jul 8, 2021

Fix for mme crash observed in test_3495_timer_for_default_bearer_with_mme_restart.py TC (#6977)

  • Added null checks, number of pdn connection tracking and missing redis state

Signed-off-by: Pruthvi Hebbani [email protected]

…ult_bearer_with_mme_restart.py TC (magma#6977)

* Added null checks, number of pdn connection tracking and missing redis state

Signed-off-by: Pruthvi Hebbani <[email protected]>
@amarpad amarpad requested review from ardzoht and pruthvihebbani July 8, 2021 17:52
@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Jul 8, 2021
@magmabot magmabot added component: agw Access gateway-related issue component: cwag CWAG related issues labels Jul 8, 2021
@amarpad
Copy link
Copy Markdown
Contributor Author

amarpad commented Jul 8, 2021

This is a clean cherry pick no local changes. I will validate the stack with s1aptester #7926

Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2021

Codecov Report

Merging #7941 (a8c10a4) into v1.5 (d707c7f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.5    #7941      +/-   ##
==========================================
- Coverage   33.58%   33.57%   -0.01%     
==========================================
  Files        1139     1139              
  Lines      101352   101383      +31     
  Branches     1318     1318              
==========================================
+ Hits        34042    34044       +2     
- Misses      63949    63978      +29     
  Partials     3361     3361              
Flag Coverage Δ
c_cpp 8.04% <0.00%> (-0.01%) ⬇️
cloud_lint 66.26% <ø> (ø)
feg-lint 56.21% <ø> (+0.01%) ⬆️
lte-test 72.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lte/gateway/c/oai/tasks/mme_app/mme_app_bearer.c 0.00% <0.00%> (ø)
...teway/c/oai/tasks/mme_app/mme_app_itti_messaging.c 0.00% <0.00%> (ø)
...e/gateway/c/oai/tasks/mme_app/mme_app_procedures.c 0.00% <0.00%> (ø)
...ay/c/oai/tasks/mme_app/mme_app_state_converter.cpp 0.00% <0.00%> (ø)
...eway/c/oai/tasks/mme_app/mme_app_state_converter.h 0.00% <ø> (ø)
lte/gateway/c/oai/tasks/nas/emm/sap/emm_cn.c 0.00% <0.00%> (ø)
.../tasks/nas/esm/DefaultEpsBearerContextActivation.c 0.00% <0.00%> (ø)
...c/oai/tasks/nas/esm/EpsBearerContextDeactivation.c 0.00% <0.00%> (ø)
lte/gateway/c/oai/tasks/nas/esm/PdnConnectivity.c 0.00% <0.00%> (ø)
lte/gateway/c/oai/tasks/nas/esm/esm_ebr_context.c 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d707c7f...a8c10a4. Read the comment docs.

@ardzoht ardzoht changed the title [agw][bug fix] Fix for mme crash observed in test_3495_timer_for_defa… fix(mme): Fix for mme crash observed in test_3495_timer_for_defa… Jul 8, 2021
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarpad amarpad merged commit 1ed1ff9 into magma:v1.5 Jul 12, 2021
@amarpad amarpad deleted the pick_2 branch July 12, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue component: cwag CWAG related issues size/XL Denotes a Pull Request that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants