Skip to content

[lte][agw] Fix itti message construction with correct apn size#7901

Merged
ulaskozat merged 2 commits intomagma:masterfrom
ulaskozat:bug_fix_apn_number
Jul 2, 2021
Merged

[lte][agw] Fix itti message construction with correct apn size#7901
ulaskozat merged 2 commits intomagma:masterfrom
ulaskozat:bug_fix_apn_number

Conversation

@ulaskozat
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat commented Jul 2, 2021 •
edited
Loading

Signed-off-by: Ulas Kozat [email protected]

Summary

GRPC response on apn configuration is not translated correctly onto itti message when the number of returned APN configurations is larger than the maximum allowed by the MME.

Test Plan

Run full suite of integ tests locally.

Modified s1ap tests.

Output of sudo journalctl -fu magma@mme with APNs exceeding the limit:

Jul 02 01:41:46 magma-dev-focal mme[1864056]: Received SGW IP Address 0x629000757228
Jul 02 01:41:46 magma-dev-focal mme[1864056]: Received SGW IP Address 0x6290007a2228
Jul 02 01:41:46 magma-dev-focal mme[1864056]: Received SGW IP Address 0x6290007ac228
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [INFO] Sending S6A-AUTHENTICATION_INFORMATION_REQUEST with IMSI: 001010000000001
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [INFO] Received S6A-AUTHENTICATION_INFORMATION_ANSWER for IMSI: 001010000000001; Status: ; StatusCode: 2001
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [DEBUG] Sending S6A-UPDATE_LOCATION_REQUEST with IMSI: 001010000000001
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [INFO] Received S6A-LOCATION-UPDATE_ANSWER for IMSI: 001010000000001; Status: ; StatusCode: 2001
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [WARNING] The number of APNs configured in subscriber data (11) is larger than MME limit of 10. Truncating the list to this MME limit.
Jul 02 01:41:46 magma-dev-focal mme[1864056]: [INFO] sent itti S6A-LOCATION-UPDATE_ANSWER for IMSI: 001010000000001

Additional Information

  • This change is backwards-breaking

@ulaskozat ulaskozat requested review from a team and ardzoht July 2, 2021 00:53
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 2, 2021
@ulaskozat ulaskozat added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 labels Jul 2, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2021

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@magmabot magmabot added the component: agw Access gateway-related issue label Jul 2, 2021
ardzoht
ardzoht approved these changes Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice fix!

amarpad
amarpad approved these changes Jul 2, 2021
View reviewed changes
lte/gateway/c/core/oai/lib/s6a_proxy/proto_msg_to_itti_msg.cpp
SUBSCRIBER_PERIODIC_RAU_TAU_TIMER_VAL;

// apn configuration
itti_msg->subscription_data.apn_config_profile.nb_apns = msg.apn_size();
Copy link
Copy Markdown
Contributor

@amarpad amarpad Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log a warning if apn_size is greater than MAX_APN_PER_UE?

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jul 2, 2021
@ulaskozat ulaskozat merged commit ce178a9 into magma:master Jul 2, 2021
@ulaskozat ulaskozat deleted the bug_fix_apn_number branch July 2, 2021 03:07
themarwhal pushed a commit that referenced this pull request Jul 2, 2021
@ulaskozat @themarwhal
[lte][agw] Fix itti message construction with correct apn size (#7901)
be276f4 
* Fix itti message construction with correct apn size

Signed-off-by: Ulas Kozat <[email protected]>

* Added log message and cleaned up the code

Signed-off-by: Ulas Kozat <[email protected]>
veshkemburu pushed a commit to veshkemburu/magma that referenced this pull request Jul 6, 2021
@ulaskozat @veshkemburu
[lte][agw] Fix itti message construction with correct apn size (magma…
9bafd32 
…#7901)

* Fix itti message construction with correct apn size

Signed-off-by: Ulas Kozat <[email protected]>

* Added log message and cleaned up the code

Signed-off-by: Ulas Kozat <[email protected]>
@themarwhal themarwhal removed the apply-v1.5 Apply this commit to the v1.5 release branch as well. label Jul 8, 2021
@themarwhal
Copy link
Copy Markdown
Member

themarwhal commented Jul 8, 2021

This is non-trivial to backport to 1.5 due to the directory layout change. @ulaskozat do you mind raising a PR against 1.5 directly?

@amarpad
Copy link
Copy Markdown
Contributor

amarpad commented Jul 8, 2021

git cherry-pick should be able to handle directory reparenting, it didn't work for you?

@amarpad
Copy link
Copy Markdown
Contributor

amarpad commented Jul 8, 2021

Also if we land it after the changes I am cherry picking it might land cleaner.

veshkemburu pushed a commit to veshkemburu/magma that referenced this pull request Jul 8, 2021
@ulaskozat @veshkemburu
[lte][agw] Fix itti message construction with correct apn size (magma…
2b13d3f 
…#7901)

* Fix itti message construction with correct apn size

Signed-off-by: Ulas Kozat <[email protected]>

* Added log message and cleaned up the code

Signed-off-by: Ulas Kozat <[email protected]>
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
@ulaskozat @rmeleromira
[lte][agw] Fix itti message construction with correct apn size (magma…
ab49b15 
…#7901)

* Fix itti message construction with correct apn size

Signed-off-by: Ulas Kozat <[email protected]>

* Added log message and cleaned up the code

Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ramon Melero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardzoht ardzoht ardzoht approved these changes

+1 more reviewer

@amarpad amarpad amarpad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

apply-v1.6 backported-v1.6 component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ulaskozat @themarwhal @amarpad @ardzoht @magmabot