perf(pipelined): Avoid service reatart on bridge reconfigure#7851
Merged
pshelar merged 1 commit intomagma:masterfrom Jul 16, 2021
Merged
perf(pipelined): Avoid service reatart on bridge reconfigure#7851pshelar merged 1 commit intomagma:masterfrom
pshelar merged 1 commit intomagma:masterfrom
Conversation
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
koolzz
approved these changes
Jun 30, 2021
Bridge reconfigure can result in mac address change. pipelineD can use mac address of egress interface to avoid handling this change. This improves restart time of pipelineD. Signed-off-by: Pravin B Shelar <[email protected]>
pshelar
force-pushed
the
enh-avoid-service-restart-non-nat
branch
from
6f050dc to
eba42a8
Compare
Contributor
feg-workflow 2 files 145 suites 29s ⏱️ Results for commit eba42a8. |
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
) Bridge reconfigure can result in mac address change. pipelineD can use mac address of egress interface to avoid handling this change. This improves restart time of pipelineD. Signed-off-by: Pravin B Shelar <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
pshelar
added a commit
to pshelar/magma
that referenced
this pull request
Aug 3, 2021
…figure (magma#7851) Bridge reconfigure can result in mac address change. pipelineD can use mac address of egress interface to avoid handling this change. This improves restart time of pipelineD. Signed-off-by: Pravin B Shelar <[email protected]>
pshelar
added a commit
that referenced
this pull request
Aug 17, 2021
…figure (#7851) (#8428) Bridge reconfigure can result in mac address change. pipelineD can use mac address of egress interface to avoid handling this change. This improves restart time of pipelineD. Signed-off-by: Pravin B Shelar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge reconfigure can result in mac address change. pipelineD can
use mac address of egress interface to avoid handling this change.
This improves restart time of pipelineD.
Signed-off-by: Pravin B Shelar [email protected]
Summary
Test Plan
Validate on Non-NAT setup.
Additional Information