subscriberdb service misc fixes related to apn resource handling#7846
Merged
hcgatewood merged 3 commits intomagma:masterfrom Jun 30, 2021
Merged
subscriberdb service misc fixes related to apn resource handling#7846hcgatewood merged 3 commits intomagma:masterfrom
hcgatewood merged 3 commits intomagma:masterfrom
Conversation
Signed-off-by: Yuanyuting Wang <[email protected]>
pull-request-size
bot
added
the
size/XL
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
wangyyt1013
force-pushed
the
subscriberdb_fixes
branch
from
b6e51ce to
15e140c
Compare
Signed-off-by: Yuanyuting Wang <[email protected]>
wangyyt1013
force-pushed
the
subscriberdb_fixes
branch
from
15e140c to
5f7eaa4
Compare
hcgatewood
suggested changes
Jun 30, 2021
Contributor
hcgatewood
left a comment
hcgatewood
left a comment
There was a problem hiding this comment.
Looks great, main thing is the q on the lte/protos/apn.proto change
|
|
||
| // TestConvertSubEntsToProtos is a regression test to check if ConvertSubEntsToProtos | ||
| // properly filters for the apn associations of a subscriber. | ||
| func TestConvertSubEntsToProtos(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Did this fail with the original implementation?
Signed-off-by: Yuanyuting Wang <[email protected]>
wangyyt1013
force-pushed
the
subscriberdb_fixes
branch
from
9a28f23 to
3fd4682
Compare
pull-request-size
bot
added
size/L
hcgatewood
approved these changes
Jun 30, 2021
Contributor
hcgatewood
left a comment
hcgatewood
left a comment
There was a problem hiding this comment.
Lgtm, thanks for the fixes!
themarwhal
pushed a commit
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Yuanyuting Wang <[email protected]>
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
…ma#7846) Signed-off-by: Yuanyuting Wang <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuanyuting Wang [email protected]
Summary
subscriberdb.ConvertSubEntsToProtosto properly filter for apn associations of subscribersgetApnResourcesDigestinsubscriberdbto take digests that capture the ingoing (from gateways) and outgoing (to apns) associations of apn resorucesTest Plan
Additional Information